sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.28k forks source link

monitoring: container monitoring should exclude jaeger side-car containers #11270

Closed slimsag closed 4 years ago

slimsag commented 4 years ago

In Kubernetes deployments each pod runs a jaeger side-car container. These are small relays, effectively, and their performance is not important or notable.

We should filter them out of the container monitoring section of all dashboards:

image

Screenshot from https://sourcegraph.com/-/debug/grafana/d/gitserver/git-server?orgId=1

slimsag commented 4 years ago

There also appears to be a POD entry that has no information:

image

I am guessing (but not completely positive) that we should filter this out, too.

This filtering can be done by editing the regexp in the dashboard's prometheus query