search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

Search: 3.18 Tracking issue #11613

Closed attfarhan closed 4 years ago

attfarhan commented 4 years ago

Plan

Our Q2 OKRs are:

The problems we want to solve this iteration:

  1. New Sourcegraph users are not given onramps for successful onboarding.

    Solution: provide a guided way for users to search relevant repositories via repository groups pages.

  2. Sourcegraph is missing familiar search features found in alternative solutions like OpenGrok. These missing features have actively turned away potential users and customers:

    I use them [boolean operators] every single day and the lack of support in Sourcegraph immediately disqualified it for us.

    There is a longstanding history of requests for this feature and it is a clear gap in our product [1, 2, 3] Solution: implement full hierarchical search with AND/OR queries behind a feature flag.

  3. Customers have asked us for a solution to search across older versions of their code. These code states live on, because they map to enterprise releases that are still being used by their customers. Some of these requests come from customers that have been on OpenGrok previously, and have spun up multiple OpenGrok instances to allow them to search old versions of code. They want to use Sourcegraph, but want a seamless solution to do so.

    Solution: enable indexing on non-main branches so searches using version contexts are fast. We have built the version contexts feature without indexing in the previous iteration.

Availability

Period is from June 22 to July 17 (20 days). Please write the days you won't be working and the number of working days for the period.

Workload

@Unassigned

@attfarhan

@keegancsmith: 10.00d

@rvantonder: 5.00d

Legend

rvantonder commented 4 years ago

Last week

This week

attfarhan commented 4 years ago

Last week

This week

asdine commented 4 years ago

Last week

This week

felixfbecker commented 4 years ago

@sourcegraph/search could https://github.com/sourcegraph/sourcegraph/issues/10820 potentially make it on the 3.18 plan? 🙂

rvantonder commented 4 years ago

@felixfbecker thanks for raising. That would need at least part of the hierarchical search work from syntax perspective (so I will be doing groundwork for it). Will be doing planning today and maybe we can squeeze it in, depends a little on how much work needs to happen in the backend.

nicksnyder commented 4 years ago

@attfarhan Can you please add a section at the top to describe "why" we are working on these things and how these things tie back to OKRs.

Here is an example for code intel: https://github.com/sourcegraph/sourcegraph/issues/11412

rvantonder commented 4 years ago

Last week

Added planning items, merge search query language reference, added search alerts, work for annotating queries with ranges and exposing these via GQL, interviews. Made progress on simplifying or-operators but the PR isn't ready yet, needs refactors.

This week

attfarhan commented 4 years ago

Last week

This week

keegancsmith commented 4 years ago

Note: My main update will go on the cloud team tracker. I'll still post search related updates here, but today is mostly about search so cross-posting: https://github.com/sourcegraph/sourcegraph/issues/11494#issuecomment-651120375

nicksnyder commented 4 years ago

@attfarhan Thanks for adding the plan section to the description! I think the problem statements could be improved. Right now it reads like problem = !X, solution do X (the problem statement presupposes the solution). Instead, make this problem statement more user focused (e.g., when users do X then run into problem Y. solution => do Z to solve Y).

New Sourcegraph users are not given onramps for successful onboarding.

How do we know this is a problem, what evidence do we have, what exactly is failing?

Users can perform complex and nested search queries to achieve feature parity with OpenGrok.

Why is feature parity with OpenGrok important? (I know that it is, but we need to document why). E.g. customers X and Y (don't say names but link to them in hubspot) decided to not use Sourcegraph because we didn't support Z.

Allow organizations to seamlessly search across contexts of their organizations code

This isn't a problem statement, it is a solution :)

attfarhan commented 4 years ago

Team update

cc @nicksnyder

OKR and work plan update:

We are tracking well towards our work plan. Last week, we made good progress towards the updated homepage and repository group pages. The first pass was implemented, and there is a draft PR open for the RFC 159 MVP. Rijnard is making progress towards enabling OR operators. Keegan is continuing to make progress on indexing non-main branches, he expects to spend this week continuing to implement this.

Notable shipped items:

Nothing to flag in terms of items that are off-track or removed from the work plan.

rvantonder commented 4 years ago

Last week

Bulk of my time spent thinking about and restructuring parser logic (currently captured by #11947). A couple of wins happen at the same time (uniform validation, less code and more shared implementation, better for migration) and also better behavior for corner cases/heuristics. Other than that, added a GQL endpoint for getting the parse tree, added onboarding items to #11779, gave feedback about search pages, investigating and helping us index repos on Sourcegraph.com.

This week

rvantonder commented 4 years ago

Last week

This week

I really wanted to have hierarchical search in shape for 3.18 release tag but it won't make it with the couple of extra items I worked on this week. This week I will continue the hierarchical search work--I actually expect it to be able to go live (behind feature flag) this week on Sourcegraph.com/cloud--it is just not ready for 3.18. Goal for 3.19 is to have this functionality on by default, and I expect that is still on course.

stefanhengl commented 4 years ago

Last week (= first week)

This week

attfarhan commented 4 years ago

Last week

This week

daxmc99 commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.18 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you