deploy-sourcegraph-dhall: gitserver: implement generate reading from config - Githubissues

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.1k stars 1.28k forks source link

deploy-sourcegraph-dhall: gitserver: implement generate reading from config #12067

Closed uwedeportivo closed 4 years ago

uwedeportivo commented 4 years ago

right now the generate function in prometheus https://github.com/sourcegraph/deploy-sourcegraph-dhall/blob/master/src/base/gitserver/generate.dhall doesn't read the configuration that is passed into it.

we want to read enough configuration to support configuring these params:

https://github.com/sourcegraph/deploy-sourcegraph-dogfood-k8s/blob/ca1a4d1a7e678f6fa65abd2fdab5047fff31000e/generated/params.sh

implement templating logic
maybe add more fields in the global config
if needed: implement transformations

provide an example pipeline config that declares the changes from dogfood for gitserver.

daxmc99 commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.18 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you

uwedeportivo commented 4 years ago

https://github.com/sourcegraph/deploy-sourcegraph-dhall/pull/10 implements this. closing to get the checkbox