sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

deploy-sourcegraph-dhall: redis: implement configuration logic for k8s.sgdev.org #12107

Open ggilmore opened 4 years ago

ggilmore commented 4 years ago

Right now the generate function in Redis https://github.com/sourcegraph/deploy-sourcegraph-dhall/blob/master/src/base/redis/generate.dhall doesn't actually read the configuration that's passed to it .

https://github.com/sourcegraph/deploy-sourcegraph-dogfood-k8s/blob/ca1a4d1a7e678f6fa65abd2fdab5047fff31000e/generated/params.sh#L92-L98

This issue tracks the work that's needed to implement the k8s.sgdev.org transformations specified for Redis in the above file.

The PR implementing this functionality will include an example pipeline configuration in the description that declares the same transformations as the ones linked above.

daxmc99 commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.18 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you

marekweb commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.19 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you