No code intelligence in browser extension (no errors, no loader) when there is rendered markdown somewhere on the page

felixfbecker commented 5 years ago

2018-12-12 21 40 11

Sourcegraph URL: https://sourcegraph.com

Background page log:

dgjhfomjieaadpoljlnidmbgkdffpack-1544647351744.log

Active extensions:

Version 18.12.12.1816 Chrome

Settings:

{
  // "sourcegraph.url": "http://localhost:3080",
  // "typescript.serverUrl": "ws://localhost:8080",
  // "typescript.langserver.log": "log",
  // "typescript.tsserver.log": "verbose",
  // "typescript.tsserver.env": {
  //   "TSC_WATCHFILE": "UseFsEvents",
  //   "TSC_NONPOLLING_WATCHER": "true",
  // },
  "typescript.npmrc": {
    "//registry.npmjs.org/:_authToken": "redacted"
  },
  "codecov.decorations.lineCoverage": false,
  "extensions": {
    "sourcegraph/logdna": false,
    "sourcegraph/codecov": false,
    "sourcegraph/code-discussions": true,
    "sourcegraph/git-extras": true,
    "sourcegraph/lang-typescript": false,
    "felixfbecker/lang-typescript": true,
    "sqs/sourcegraph-python": false,
  },
  "typescript.accessToken": "redacted",
  "go.accessToken": "redacted",
  "panel.locations.groupByFile": true,
  "basicCodeIntel.enabled": false,
  "discussions.decorations.inline": true,
  "git.blame.lineDecorations": false
  // add settings here (Cmd/Ctrl+Space to see hints)
}

https://github.com/sourcegraph/codeintellify/pull/70/files#diff-4a91ad3f5a7ed49f91943e184440a5dd

felixfbecker commented 5 years ago

It looks like the extension doesn't activate

ijsnow commented 5 years ago

Works for me

lguychard commented 5 years ago

Reproduced - .tsx diff view is never detected

lguychard commented 5 years ago

Broken by https://github.com/sourcegraph/sourcegraph/pull/1322 - this also matches rendered markdowns in PR comments

sourcegraph / sourcegraph-public-snapshot

No code intelligence in browser extension (no errors, no loader) when there is rendered markdown somewhere on the page #1359