search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

internal contributor 3.23 Tracking issue #16080

Closed slimsag closed 3 years ago

slimsag commented 3 years ago

Plan

Tracking issue for @slimsag working as an internal contributor on high-impact, low-cost wins.

Project board: https://github.com/orgs/sourcegraph/projects/106

Availability

If you have planned unavailability this iteration (e.g., vacation), you can note that here.

Not working:

Total time: 17d

Tracked issues

@unassigned

Completed

@felixfbecker

Completed

@slimsag: 5.00d

Completed

Legend

slimsag commented 3 years ago

This week:

Short week (Thanksgiving, taking two days off), spent most of Monday catching up on everything after being on vacation. Quickly fixed a syntax highlighting bug multiple users had complained about enough that one wanted to pay a bounty to have it fixed(❗). Discussed with Felix about Code Insights and how I might help there, and spent a majority of my time looking into https://github.com/sourcegraph/sourcegraph/issues/6992 - the code is very hairy/nasty here, but I anticipate completing this in 2-3 more work days. I am discussing with the search team how to measure the impact this change has and may add a new task time-boxed to 1-2d for putting something in place here to measure changes like this and streaming search.

Next week:

I expect to finish and merge a change for https://github.com/sourcegraph/sourcegraph/issues/6992 behind a feature flag, and begin looking at how to measure it.

slimsag commented 3 years ago

This week

I made slower progress towards #6992 than I wanted to, primarily because it became clear that I had to refactor a lot of spaghetti code in order to implement the fix cleanly. That said, I have:

Next week

I will finish up the search work here completely, and optimistically finish planning code insights backend work with Felix so that I can get started on that the week after next.

slimsag commented 3 years ago

Last week

Happy with the progress I made. I landed my major webapp refactor #16466 which was a per-requisite to fixing #6992. I then sent and merged both the frontend (#16571) and backend (#16570) fixes for #6992 behind a feature-flag which reduces bytes transferred for search result loading by ~50-70%.

I briefly helped resolve a Sourcegraph.com incident, and did a lot of work with Felix brainstorming how we will move forward on the Code Insights backend (overview). I put together a "learn-as-we-go" draft RFC.

This week

At the start of the week, I plan to add metrics for search-result-time-to-load (#16468) so I can determine how much we have won with my fix here #6992 and so that I can turn that feature flag on-by-default. If I have time, I will also try to implement #16467 which will further help with initial page loads.

I plan to polish up the code insights "learn-as-we-go" RFC, run it by a few others (I will have to wait until after holiday to get Felix's approval, I have Joel's approval), and begin executing on it late this week and begin taking in feedback and adapting as we go.

slimsag commented 3 years ago

Last week

Two-day week, as I just got back from holiday break. I spent the entire two days catching up on things, and mostly helping https://app.hubspot.com/contacts/2762526/company/407948923/ which has recently had a surge in activity (campaigns discussions, upgrade issues, account changes, etc.) that requires my time.

This week

Monday is lost to meetings, and I expect a day or two will go towards https://app.hubspot.com/contacts/2762526/company/407948923/ - specifically around campaigns discussions and https://github.com/sourcegraph/customer/issues/175

I aim to spend a majority of my time this week actually starting on code insights backend work.

slimsag commented 3 years ago

Picking up here: https://github.com/sourcegraph/sourcegraph/issues/17737