search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.29k forks source link

Private mode requires authentication" error message is not discoverable #1741

Closed attfarhan closed 5 years ago

attfarhan commented 5 years ago

Steps to reproduce:

  1. Point your browser extension to sgdev.
  2. Sign out of sgdev. Sign in with OpenIDConnect.
  3. On GitHub or GitLab, go to a file in a repository not on sgdev (e.g. if you're pointing your repo to sgdev, go to https://github.com/tsenart/vegeta/blob/master/internal/cmd/echosrv/main.go)
  4. Hover over a token, and see that a line appears above the token. Open the browser console and see 401 errors that say "private mode requires authentication". I was not sure of what to do, but remembered we had a GitHub sign-in option, which I used, and solved the problem.

2019-01-09 21 48 53

Expected behavior:

The line above the token when hovering should not appear, or a hover should appear showing the error message "private mode requires GitHub/GitLab/CodeHost authentication" or something more specific.

Actual behavior:

The line above tokens appear when hovering and the ambiguous "private mode requires authentication" message appears in the console.

attfarhan commented 5 years ago

This seems like it could be an edge case, since we have multiple sign-in options (I don't think most instances will have multiple), so not sure if it should be release blocking.

sqs commented 5 years ago

@ijsnow is not working between now and the release, this is not a new issue, this is a browser extenson issue (so can be fixed without requiring customer redeploy) -- so pushing to 3.1

ijsnow commented 5 years ago

Reassigning to you to triage/prioritize @lguychard