Branch/Tag/Commit selector: Show more summary is not displayed

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.1k stars 1.29k forks source link

Branch/Tag/Commit selector: Show more summary is not displayed #21060

Open umpox opened 3 years ago

umpox commented 3 years ago

Steps to reproduce:

Open the Branch/Tag/Commit selector on the 'Commit' view where there are multiple pages of commits

Expected behavior:

'Show more' button is displayed
Summary text is displayed: e.g. X commits total (showing first 50)

Actual behavior:

'Show more' button is displayed
Summary text is not displayed

Notes:

When debugging this, it seems that the summary text is created, but only when 'Show more' is clicked. It should display at all times, unless we are loading more results

github-actions[bot] commented 3 years ago

Heads up @alicjasuska @umpox @valerybugakov @5h1ru @pdubroy - the "team/frontend-platform" label was applied to this issue.

gitstart-sourcegraph commented 3 years ago

@valerybugakov We can make changes like return the actual "first" in the useConnection but since the api doesn’t return “TotalCount”, so we couldn’t build the expected summary like the one in ticket desc .i.e. “X commits total (showing first 50)”

We can only build something like “Showing 50" with "Show more” button or “Showing all 115” (without "Show more" button after loaded all). What do you think about it? Are you ok with those texts or we should update BE API to get enough informations to build the expected texts?

umpox commented 3 years ago

@gitstart-sourcegraph I think the correct solution here would be to de-prioritise this as it'll require backend changes. Fixing totalCount is the correct solution here but there are more unknowns than I think are suitable for these initial tickets!