search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.27k forks source link

insights: insights percy tests are flaky #23416

Open coury-clark opened 3 years ago

coury-clark commented 3 years ago

Some insights Percy tests are failing in CI on unrelated builds

https://percy.io/Sourcegraph/Sourcegraph/builds/11836050/changed/666183933?browser=chrome&browser_ids=16&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=1920

https://percy.io/Sourcegraph/Sourcegraph/builds/11834416/changed/666108534?browser=chrome&browser_ids=16&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1920&widths=1920

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/code-insights" label was applied to this issue.

coury-clark commented 3 years ago

Another example https://percy.io/Sourcegraph/Sourcegraph/builds/11913710/changed/670626389?browser=chrome&browser_ids=16&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1920&widths=1920

coury-clark commented 3 years ago

Another example - am I wrong in thinking this is actually the line itself that is rendering slightly differently? @vovakulikov

https://percy.io/Sourcegraph/Sourcegraph/builds/12604837/changed/711662803?browser=chrome&browser_ids=16&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1920&widths=1920

vovakulikov commented 3 years ago

Hmm. I will take a look at this but it's something new. Thanks for reporting thing @coury-clark 👍