postMessage() could not clone error when activate() function throws

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.11k stars 1.27k forks source link

postMessage() could not clone error when activate() function throws #2460

Open felixfbecker opened 5 years ago

felixfbecker commented 5 years ago

When the activate function of an extension throws, an error is logged about the Error not being cloneable. It should convert the error to a plain object (may be a bug in comlink).

sentry-io[bot] commented 5 years ago

Potential Sentry issue: SOURCEGRAPH-DOT-COM-B

lguychard commented 4 years ago

@felixfbecker do you know if we still have this issue?

felixfbecker commented 4 years ago

Yeah I think this is a bug in comlink.

lguychard commented 4 years ago

Re-investigate after https://github.com/sourcegraph/sourcegraph/issues/3989 (we should not fix it in our fork of Comlink v3)

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.