search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.27k forks source link

authz/github: permissions sync with read-only access #27872

Open bobheadxi opened 2 years ago

bobheadxi commented 2 years ago

The current requirement for write access for complete permissions sync to work with GitHub is one that faces considerable pushback from certain customers.

We can rely purely on user-centric sync, however, in the event we only get read access (described in this discussion) - this happens almost "by accident", and we do not have strong support for it such as tests (we are just fairly certain this will work for the most part on paper at least). I've previously gone the route of keeping this as an undocumented workaround available on request, but #27804 makes it explicit that this works and I think we should look into providing proper support (tests, docs, etc.) with the documented caveats.

I'm vaguely aware that GitHub apps might be a solution to this (1, 2), but I haven't delved too deeply into it. @emchap also provided a link to some feedback, though I do not have access to Salesforce.

github-actions[bot] commented 2 years ago

Heads up @jplahn @dan-mckean - the "team/repo-management" label was applied to this issue.