Search Reevaluates space in Azure Devops project name incorrectly

[Ollie-Armitage]

• Sourcegraph version: 3.34.2
• Platform information: Ubuntu 20.10 LXC Container, Docker Container

Steps to reproduce:

1. Have a project with a space in the name on azure devops with repo
2. Link repo (using %20 for the space in project name)
3. Perform a search for anything in the repo
4. Click on repo item

Expected behavior:

Project name is not changed, and repo is found.

Actual behavior:

Project Name parses incorrectly ("%20" => "\ ") giving 'repository not found'

If would like immediate help on this, please email support@sourcegraph.com (you can still create the issue, but there are not SLAs on issues like there are for support requests).

[github-actions[bot]]

Heads up @benvenker @lguychard - the "team/search-product" label was applied to this issue.

[rvantonder]

I've worked on something related, a while back, re: repos with spaces and have tested against this Azure repo with a space: https://dev.azure.com/rvantonderp/repo%20with%20space successfully. But perhaps, only tested that the repo is found. I suspect the issue here comes down to these steps in the bug report:

3. Perform a search for anything in the repo
4. Click on repo item

Likely clicking on a repo item is not unencoding the space properly in the match view, and leaving the %20 in place.

[camdencheek]

We've since changed how repo links are generated. I would expect this is fixed now, but someone should test this.