search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.28k forks source link

zoekt: work out why incremental gitserver interactions fail sometimes #29695

Closed keegancsmith closed 8 months ago

keegancsmith commented 2 years ago

I have seen this pop up a few times, most recently #inc-68-zoekt-index-is-stuck-on-a-4-hour-old-commit-for-srcsrc. I added a mitigation, but I need to dive in to work this out since this may be happening more than we think.

First port of call is detailed observability around repository updates in gitserver. This will also help me understand what is happening in zoekt.

github-actions[bot] commented 2 years ago

Heads up @jjeffwarner - the "team/search-core" label was applied to this issue.

keegancsmith commented 2 years ago

I'm pausing work on this for this week, will reconsider next week.

keegancsmith commented 2 years ago

FYI I did some refactorings in preperation for fixing this on Friday. I believe I root caused the issue to do with us mishandling gitserver being down.

Refactors:

stefanhengl commented 8 months ago

This issue has been inactive for a long time. To reopen the ticket, please let us how to reproduce the issue on latest main. For feature requests, please let us know what is still missing.