search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

insights: Code Insights API does not emit graphql metrics #30254

Open coury-clark opened 2 years ago

coury-clark commented 2 years ago

We monitor our GraphQL endpoints using some metric names src_http_request_duration_seconds_bucket src_graphql_field_seconds_bucket. It seems none of the Code Insights endpoints or fields are in these metrics, so we may need to add them deliberately.

github-actions[bot] commented 2 years ago

Heads up @joelkw @felixfbecker @vovakulikov @unclejustin - the "team/code-insights" label was applied to this issue.

coury-clark commented 2 years ago

It seems we are actually capturing the http request on k8s - I mistakenly thought this was broken from reading a dashboard on sourcegraph.com (where insights is disabled). However, it seems the GraphQL fields are still not available. This is ultimately coming from this Tracer - perhaps we need to include some header to trace each field?

CristinaBirkel commented 2 years ago

@coury-clark Looking into this, I'm not sure I understand exactly what we're going for here. I am seeing insights endpoints showing up when looking at metrics for src_http_request_duration_seconds_bucket and src_graphql_field_seconds_bucket. (By searching src_http_request_duration_seconds_bucket{route=~".*Insight.*"} for example.)

And based on the more recent comment, I'm not sure I understand what fields we want to show up there. It looks like the allowed fields are all hardcoded.

Is there an endpoint that I can look at as an example of how this is meant to be working?