search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.28k forks source link

Definition navigation does not work if URL is set to definition location #30556

Open jjinnii opened 2 years ago

jjinnii commented 2 years ago

Steps to reproduce:

Taken from internal feedback:

  1. Navigate to URL - URL is set to definition location at line 160 in this file =
  2. Click on "go to definition" or j2d click on the symbol at line 108

Expected behavior:

Even if URL is somehow set to definition location, if user is trying to navigate to the definition location while on a different line in the file, we should re-direct users to definition location.

Actual behavior:

Flakey performance. Sometimes I'm re-directed to line 160 definition location, and other times the definition button/j2d doesn't do anything.

CleanShot 2022-02-01 at 11 20 14

github-actions[bot] commented 2 years ago

Heads up @macraig - the "team/code-intelligence" label was applied to this issue.