Performance improvements for workspace resolution

eseliger commented 2 years ago

Workspace resolution is currently resource-hungry and can be slow for larger instances.

There are a few things I've identified that could be good improvements here:

We can run the search from the worker itself. The search API has been refactored to run on any service now. This will help with resource contention on the frontend while the workspace resolver is running. 1.5d
- There are currently two things that need to be solved before we can make it happen:
- The logic to get user settings is still in the GQL layer, it would need to be factored out (good refactor in general)
- The worker pod doesn't have all the env vars that are required to run all kinds of searches. Ideally it could get these config values from the frontend instead of us duplicating all the env vars across services. Done
Parallelize resolving on sections 1.5d
Investigate if we can use gitserver directly instead of search for FindDirectoriesInRepos, this runs for each repository. Ideally this also uses a batch method. 1-5d? needs investigation

courier-new commented 1 year ago

eseliger commented 1 year ago

@courier-new did you want to split this into separate tickets or do I misremember? This was in sustaining before, so maybe 1 or 2 of the resulting tickets we might want to consider for the sustaining sprint?

courier-new commented 1 year ago

I saw it was in sustaining, so I wanted to leave it for us to talk about at sprint planning, to figure out which parts of it (if any) we want to tackle before splitting the issue up. 🙂 I figure we could split out the parts we want to work on into separate tickets and leave the rest here as a catch-all.

courier-new commented 1 year ago

Do you think you could help me with estimates for the items individually here, though, to prepare for tomorrow? 🙏

courier-new commented 1 year ago

Split out two separate issues for the two things we thing would have the biggest impact:

I'll label these remaining items as strategic-ready/low, and they will go to the backlog.

sourcegraph / sourcegraph-public-snapshot

Performance improvements for workspace resolution #36260