Remove style duplication caused by the `forkedBranded.scss` file - Githubissues

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.1k stars 1.28k forks source link

Remove style duplication caused by the `forkedBranded.scss` file #39285

Open valerybugakov opened 2 years ago

valerybugakov commented 2 years ago

Problem statement

Duplicated branded.scss in the VSCode package makes it hard to keep the theme consistent between all Sourcegraph clients.

Success criteria

The forkedBranded.scss file is removed in favor of the branded.scss import.

Implementation details

Rename client/branded/src/global-styles/index.scss to client/branded/src/global-styles/base.scss
Move @import './highlight'; from base.scss to client/branded/src/global-styles/index.scss
client/vscode/src/webview/index.scss should import client/branded/src/global-styles/base.scss instead of forkedBranded.scss
All style changes specific to the VSCode theme should be made in the client/vscode/src/webview/index.scss

Time estimate

The task should take 8 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.

gitstart-app[bot] commented 2 years ago

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-39285