sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

Extract bootstrap style import `@import 'bootstrap/scss/card'` in `client/vscode` #39363

Open gitstart-sourcegraph opened 2 years ago

gitstart-sourcegraph commented 2 years ago

Problem statement

We depend on Bootstrap styles in our global styles a lot. But we don't plan to move forward with Bootstrap because we're working on our design system called Wildcard. To ease the transition to our styles and gain more control over visual changes, we want to move Bootstrap styles that we need into our codebase and eventually drop Bootstrap dependency.

Ref

https://github.com/sourcegraph/sourcegraph/issues/39345

Success criteria

  1. All use cases of card-* are migrated to use wildcard's Card component.

Implementation details

  1. Remove bootstrap import @import 'bootstrap/scss/card' in forkedBranded.scss.
  2. Covert use cases of card-* className to Card wildcard component.
  3. If step 2. above is not doable, let's copy style rule from bootstrap to be used internally.

Time estimate

gitstart-app[bot] commented 2 years ago

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-39363

sourcegraph-bot-2 commented 2 years ago

Heads up @taylorsperry @jasongornall - the "team/frontend-platform" label was applied to this issue.