Open limitedmage opened 2 years ago
From the customer, turning on enableFastResultLoading
"does speed things up a bit, by an order of magnitude it looks like, but that takes it from 2 minute loads per graphql query to ~1.2", which is better but still unacceptable IMO. Maybe caching the syntax highlighted files could improve this, as this is mostly happening on the same files for this customer (large 50,000+ line .gitmodules
files, one in each repo).
Since search results only render a small context from the file, would it make sense to tweak syntax-highlighter to optionally accept a list of lines to highlight +/- context? Syntect highlights files one line at a time so it should be fairly easy to tweak the core loop to skip lines that don't need highlighting.
Issue reported by https://github.com/sourcegraph/accounts/issues/8205 Network trace available at https://drive.google.com/file/d/1Mc899L8ckNAIQVac791xYKgD9LJAra_T/view?usp=sharing
Steps to reproduce:
"search.largeFiles": ["**/**"]
so very large files are all indexedExpected behavior:
Results load
Actual behavior:
Results load with blank boxes and take forever to populate, if ever. The network tab shows that syntax highlighting is pending for a very long time; it may eventually complete or time out.