search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

Remove the command palette from the browser extensions #41114

Open philipp-spiess opened 2 years ago

philipp-spiess commented 2 years ago

For 4.0, we agreed to remove the command palette on web since only extensions could provide implementations for it and without any extensions it would serve no purpose anymore.

We should make sure to do the same in code hosts via the browser extensions when we detect post 4.0 instances.

Screenshot 2022-08-31 at 12 45 08

/cc @muratsu @jjinnii @ryankscott

philipp-spiess commented 2 years ago

Although hmm there is this one use case that my screenshot shows "Prefer non-Sourcegraph hover tooltips" that still may be worth keeping. Perhaps we should make a button on its own instead? cc @taras-yemets @jjinnii @ryankscott

ryankscott commented 2 years ago

@philipp-spiess I guess this is only for our native code host integration? If so, then I agree that this button could be repurposed to toggle the hover behaviour.

jjinnii commented 2 years ago

Agreed that rather than keeping the command palette for this one setting, a dedicated action or button for this is preferred. That being said, I don't know if it's as simple as put a button in place of where the command palette icon used to be 😄 We could potentially explore solutions where this setting could be communicated within the popover (upon first use and afterwards).

I'd like to explore different options, but do we think that this is something we need to support by 4.0? cc: @ryankscott I also don't know how often users are switching back and forth btw default tooltips. From a product perspective, if a user turns off our browser extension tooltips, what else would they be using the extension for?

philipp-spiess commented 2 years ago

Agree, we don't need to make this change before the 4.0 release at all. I'll move this to the post4.0 list. Thanks Sara :)

muescha commented 2 years ago

if the command palette shows both tooltips then we need to toggle between.

then an setting in the extension option menu is ok to setup the behaviour:

see my Feedback: