sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.28k forks source link

Show `git notes` entries on commits / tags / etc #41154

Open Groxx opened 2 years ago

Groxx commented 2 years ago

Feature request description

Git notes are possibly not a widely-used tool... but they provide a nice way to add information to commits after they are created. E.g. you can use them to add "this commit caused issues X, Y, Z, we reverted it in Q" notes on the commit where the problem was introduced, not just the commit that fixed it, which is useful context when browsing history.

Unfortunately almost nothing exposes these. E.g. Github has a comment field on commits, but it just stays in Github, and it doesn't show any notes I've pushed.

Could Sourcegraph do this? It'd be handy in some cases, and might encourage using them more. They're potentially quite handy, like, why maintain a separate file for git-blame commit skipping when you could put it in a note after the fact, and have it available at all commits?

Describe alternatives you've considered.

I mean, you can always build custom commenting systems. Everyone does it.

But those aren't git clone-able. Everyone eventually loses them.

malomarrec commented 2 years ago

Hey @taylorsperry, it looks like this issue was created by someone outside Sourcegraph. Assigning you to triage it! Please answer and route to the right team by adding their team label, then remove the triage-bot/needs-triage label

jdorfman commented 2 years ago

@Groxx interesting. Do you have any popular projects using git notes? It will help determine whether this will be considered.

malomarrec commented 2 years ago

Hey @taylorsperry, just a reminder to triage this issue and remove the triage-bot/needs-triage label when you're done!

taylorsperry commented 2 years ago

Not sure Code Intel is the right team for this. WDYT @macraig ?

macraig commented 2 years ago

@ryphil do you know if is this data accessible from gitserver? If so it would be something code intel or search can expose.