search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

CodeMirror blob: clicking on "Go to definition" with a single definition does not hide the popover #41730

Open olafurpg opened 2 years ago

olafurpg commented 2 years ago

Currently, the popover remains loaded after clicking on "Go to definition" when the definition location is behind the popover

CleanShot 2022-09-19 at 13 34 45

Link to reproduce https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/ui/assets/load_manifest_dev.go?L22

I'm unable to reproduce the old blob view. (see discussion below)

fkling commented 2 years ago

Mmh, I do get the same behavior in the old blob view.

fkling commented 2 years ago

Mmh, I do get the same behavior in the old blob view.

fkling commented 2 years ago

Mmh, I do get the same behavior in the old blob view.

fkling commented 2 years ago

Mmh, I do get the same behavior in the old blob view.

fkling commented 2 years ago

Thank you broken GH UI.

olafurpg commented 2 years ago

I'm also able to reproduce this issue with the old blob view. I swear I remember confirming the popover disappeared with the old blob view but it must have been something else.

I changed the priority from P1 to P2 since it's only a nice-to-have if the old blob view has the same behavior.