sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

Test Perforce Java and Python libraries for permissions handling #42525

Open jplahn opened 2 years ago

jplahn commented 2 years ago

We've implemented our own rules matching logic for p4 protects tables. Perforce provides a C++ and Java library that we should test and compare against our own implementation so we can decide whether to deprecate our own implementation in favor of those libraries.

  1. Java library: https://github.com/perforce/p4java/tree/master/src/main/java/com/perforce/p4java/mapapi
  2. Python library: https://github.com/perforce/p4python

/cc @jplahn @ryphil

peterguy commented 1 year ago

estimating 1 day for research. This should probably be a pretty low priority issue as long as our current tools work well enough and there won't be breaking changes to the Perforce protects table.

Instead of writing something in Java or Python, we may want to write our own tool using the Perforce C++ API, maybe in Go using cgo.