sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

[Accessibility]: Tables in code excerpts should use headers for line numbers #43144

Open limitedmage opened 2 years ago

limitedmage commented 2 years ago

Audit type

ARC Toolkit

User journey audit issue

https://github.com/sourcegraph/sourcegraph/issues/34190

Problem description

ArcToolkit says the tables used for search results are confusing because a11y tools can't tell if the table is tabular data or used for layout purposes. We need to clarify this.

Expected behavior

The table should switch the line numbers from being <td> to <th>. This will clarify that this is indeed a table with tabular data. ArcToolkit should not show alerts about tables.

CleanShot 2022-10-18 at 15 52 06@2x

Additional details

No response

Assigning labels

Owner

This issue will be fixed by GitStart. I have assigned the label 'gitstart' and added the assignee 'gitstart-sourcegraph'.

/cc @lguychard

gitstart-app[bot] commented 2 years ago

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-43144

felixfbecker commented 1 year ago

Reopening since https://github.com/sourcegraph/sourcegraph/pull/44514 was reverted

limitedmage commented 1 year ago

I'll work to restore the original PR and fix the issues that led to the revert.