sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

Combobox: Bring in-house version of combobox #43236

Open vovakulikov opened 2 years ago

vovakulikov commented 2 years ago

Background

At the moment we do have wildcard abstractions for combobox UI pattern, but these abstraction are based on reach-ui combobox component Since reach-ui is no longer maintained https://github.com/reach/reach-ui/issues/972 there is no a clear way to contribute to reach-ui in order to improve combobox or other parts of reach-ui package.

For example, for combobox we do have one issue that may block us from using combobox widely in our app https://github.com/reach/reach-ui/issues/979. This is just one example of problems like this. We do have more of them but since Combobox UI doesn't expose enough API we can't fix them outside of Combobox UI.

In this issue we should fork or reimplement reach ui combobox in a way that it would be possible for us to support all missing features that Combobox at the moment doesn't have and can't have because of reach ui implementation.

Missing features

/cc @sourcegraph/frontend-platform

olafurpg commented 2 years ago

Some functionality in the fuzzy finder that would be desirable to have in a shared combobox (and it might already be supported by the existing combobox):