sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

Unify search latency, duration, and event collection in `LogJob` #45466

Open camdencheek opened 1 year ago

camdencheek commented 1 year ago

The stream and GraphQL APIs used to work very differently, so they have very different metrics and event logging. However, now the streaming API and GraphQL API both use the same underlying machinery, so it makes sense to unify the metrics and event logging so that the numbers are directly comparable.

What would this look like?

This also has the effect of having good observability on all searches, even ones from weird sources like the Stats endpoint or code monitors.

github-actions[bot] commented 1 year ago

Hey, @sourcegraph/batchers (@eseliger @LawnGnome @courier-new @adeola-ak @BolajiOlajide @Piszmog @malomarrec @chrispine @danielmarquespt) - we have been mentioned. Let's take a look.

camdencheek commented 1 year ago

lol, sorry batchers, just a function name

eseliger commented 1 year ago

You’ll have to take our opinions now 😇

camdencheek commented 1 year ago

I'll always take the opinion of an /Eri(c|k)/

jtibshirani commented 11 months ago

I'm going to unassign myself, since I'm thoroughly onboarded by now and someone else can benefit from this well-scoped idea :)