search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.29k forks source link

codenav: Bitbucket Server j2d on local symbol brings user to Sourcegraph code view #4592

Closed tsenart closed 2 years ago

tsenart commented 5 years ago

Steps to reproduce:

  1. Ensure your Sourcegraph extension is configured to use https://k8s.sgdev.org
  2. Go to https://bitbucket.sgdev.org/projects/SOUR/repos/vegeta/browse/main.go#88
  3. Authenticate with 1 Password credentials
  4. Click on fs and then "Go to definition"

Expected behavior:

Jumps to definition of the symbol in the same file view.

Actual behavior:

Jumps to definition of the symbol in Sourcegraph.

lguychard commented 5 years ago

Same code host jump-to-def currently only works on GitHub, CodeHost.urlToFile() is not implemented for any other code host. Backlogging, although this is not a huge effort and we may want to tackle it soon.

tsenart commented 5 years ago

I was about to file an issue for this and realised I had filed this last iteration :-)

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.