No code intelligence on commit views on recent Phabricator versions

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.12k stars 1.29k forks source link

No code intelligence on commit views on recent Phabricator versions #4621

Open lguychard opened 5 years ago

lguychard commented 5 years ago

Steps to reproduce:

bitnami/phabricator version: >= 2019.21.0-r25
Navigate to a commit views
Hover tokens

Expected behavior:

Code intelligence hovers appear

Actual behavior:

Code intelligence hovers don't appear

Notes

getLineNumberCellFromCodeElement() expects the line number cell to be a <th>, but on recent Phabricator versions it's a <td> with a data-n attribute:

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.

vdavid commented 2 years ago

This might still be a bug, but we couldn't make code intel work in Phabricator yet, so until our tooling is fixed and we can make sure that this is a non-issue, we'll have this open.