Closed lguychard closed 5 years ago
Note: this should be prevented by the injection of a .sourcegraph-app-background
by the native integration, but the way the browser extension checks it is racy: https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/browser/src/extension/scripts/inject.tsx#L46-52
The link points to a comment saying it's not racy?
I meant to close this, the comment was added in #4835 after I investigated this further and determined that it was, in fact, not racy - I had been misled by the "Sourcegraph browser extension is running"
console log, which is always logged even when the browser extension code bails due to the presence of the native integration.
Steps to reproduce:
Expected:
Only the native integration is executed, the browser extension doesn't run.
Actual:
Browser extension and native integration are both running.