Change changeset archive behavior for merged changesets

[BolajiOlajide]

Context

When applying a new spec and reconciling a changeset, if the current spec no longer targets it, we will:

• Mark it as archived in the batch change if it's published and open on the code host
• Do not mark it as archived in the batch change if it's published and already closed/merged on the code host
• Do whatever we do currently (no change) if it's not published

[BolajiOlajide]

We discussed this during the team sync.

There seems to be a disconnect in our message with the Archived status. We'll improve that by displaying only closed changesets in the Archived tab. Changesets that were merged before being archived will be displayed in the usual changeset view and the version of the batch spec attached to it.

We'd version batch specs (especially for SSBC) so users can click and go to the execution that created a changeset.

[courier-new]

Thanks for the write-up, Bolaji. Can I repurpose this issue for that solution, then? I'm seeing two changes here, is this accurate?

To be done now:

When applying a new spec and reconciling a changeset, if it is no longer targeted by the current spec, we will:

• Mark it as archived in the batch change if it's published and open on the code host
• Not mark it as archived in the batch change if it's published and already closed/merged on the code host
• Do whatever we do currently (no change) if it's not published

To be done in the future (needs design):

• In the UI, surface the batch spec execution that produced a changeset, if it's not the current execution, with some indicator and a link to the execution itself

[courier-new]

@BolajiOlajide if you could confirm the above and clean this up/add any additional issues we need, then unassign yourself and move them to the backlog.

[courier-new]

@BolajiOlajide reminder if you could please update this issue and create any others to get it in a state that reflects what we've decided to do with the archiving behavior. 🙂

[BolajiOlajide]

I can't continue the work on this ticket due to my focus on higher priorities in the current job fair cycle (aka Commit Signing).

I have a draft PR that whoever picks this up can build on. The PR updates the SQL for computing changeset stats so that merged changesets aren't computed as ARCHIVED anymore.

The remainder of the work to be done here is to update the applyPreview field so that merged changesets that don't belong to the current spec aren't labeled as ARCHIVED anymore.