Browser extension & native integration conflicting on Bitbucket Server

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.1k stars 1.29k forks source link

Browser extension & native integration conflicting on Bitbucket Server #4900

Open tsenart opened 5 years ago

tsenart commented 5 years ago

Sourcegraph version: 3.6.0-rc.1

Steps to reproduce:

Point your Sourcegraph extension to https://k8s.sgdev.org
Go to https://bitbucket.sgdev.org/projects/SOUR/repos/vegeta/browse/encode.go?at=master#88
Hover over the NewCSVEncoder symbol and move the pointer horizontally over the symbol until two tooltips pop-up.

Expected behavior:

Only one tooltip shows up.

Actual behavior:

Two tooltips are shown, although with different content (note how the one in the back has the type of the argument as io.Writer and the one in the front only Writer).

tsenart commented 5 years ago

cc @keegancsmith

lguychard commented 5 years ago

I had tested for conflicts extensively with the dev extension, and hadn't found any issues, with the browser extension reliably detecting that the native integration was already running, and stopping execution:

However, with the prod browser extension, conflict with the native integration can occur, with racy behaviour between content script injection & native integration init (see duplicate "detected code host bitbucket server" log):

tsenart commented 5 years ago

@nicksnyder handed over verification of this back to me. When should I take a look at it again?

lguychard commented 5 years ago

@tsenart I'm waiting for a final review from @felixfbecker on #4927. I'll ping you when it's merged & has made it into an RC.

keegancsmith commented 5 years ago

Yeah I am aware of this, once it lands I will cherry-pick and create a new RC. Our only "important" release blocker, so very keen to get it into the release :)

christinaforney commented 5 years ago

Reopening, since there is a new issue:

There are two repo level sourcegraph buttons in BbS shown when extension and native extension are enabled
Hovers are not conflicting, and only one button shown at the file level
Command palette is only rendered once

We determined that the native plugin is working properly to remove browser extension elements, but the duplicate button is an artifact that is just getting left on the page. Interactions are all working as expected.

felixfbecker commented 4 years ago

This may also be an issue with Gitlab, I've seen both logs being printed at the same time.

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.