Open tsenart opened 5 years ago
cc @keegancsmith
I had tested for conflicts extensively with the dev extension, and hadn't found any issues, with the browser extension reliably detecting that the native integration was already running, and stopping execution:
However, with the prod browser extension, conflict with the native integration can occur, with racy behaviour between content script injection & native integration init (see duplicate "detected code host bitbucket server" log):
@nicksnyder handed over verification of this back to me. When should I take a look at it again?
@tsenart I'm waiting for a final review from @felixfbecker on #4927. I'll ping you when it's merged & has made it into an RC.
Yeah I am aware of this, once it lands I will cherry-pick and create a new RC. Our only "important" release blocker, so very keen to get it into the release :)
Reopening, since there is a new issue:
We determined that the native plugin is working properly to remove browser extension elements, but the duplicate button is an artifact that is just getting left on the page. Interactions are all working as expected.
This may also be an issue with Gitlab, I've seen both logs being printed at the same time.
Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.
Steps to reproduce:
NewCSVEncoder
symbol and move the pointer horizontally over the symbol until two tooltips pop-up.Expected behavior:
Only one tooltip shows up.
Actual behavior:
Two tooltips are shown, although with different content (note how the one in the back has the type of the argument as
io.Writer
and the one in the front onlyWriter
).