search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.29k forks source link

No code intel on deleted files in unified PR diff view of Bitbucket Server #4904

Closed tsenart closed 4 years ago

tsenart commented 5 years ago

Steps to reproduce:

  1. Go to https://bitbucket.sgdev.org/projects/SOUR/repos/vegeta/pull-requests/2/diff#dump.go
  2. Double click on a symbol like command.

Expected behavior:

Tooltip shows up.

Actual behavior:

No tooltip shows up and Javascript errors are logged to the console.

Error: document not found: git://bitbucket.sgdev.org/SOUR/vegeta?0f5577eaf11a136541b8c667273b6bc5eba51a8b#dump.go
    at f.get (extensionHostWorker.bundle.js:1)
    at f.getSync (extensionHostWorker.bundle.js:1)
    at async AsyncFunction.<anonymous> (extensionHostWorker.bundle.js:1)
    at async MessagePort.<anonymous> (extensionHostWorker.bundle.js:1)

Error: document not found: git://bitbucket.sgdev.org/SOUR/vegeta?0f5577eaf11a136541b8c667273b6bc5eba51a8b#dump.go
    at f.get (extensionHostWorker.bundle.js:1)
    at f.getSync (extensionHostWorker.bundle.js:1)
    at async AsyncFunction.<anonymous> (extensionHostWorker.bundle.js:1)
    at async MessagePort.<anonymous> (extensionHostWorker.bundle.js:1)

Error: document not found: git://bitbucket.sgdev.org/SOUR/vegeta?0f5577eaf11a136541b8c667273b6bc5eba51a8b#dump.go
    at f.get (blob:chrome-extension://dgjhfomjieaadpoljlnidmbgkdffpack/ce690b9d-5521-446f-8869-87860d0ace6e:1:107587)
    at f.getSync (blob:chrome-extension://dgjhfomjieaadpoljlnidmbgkdffpack/ce690b9d-5521-446f-8869-87860d0ace6e:1:107715)
    at async AsyncFunction.<anonymous> (blob:chrome-extension://dgjhfomjieaadpoljlnidmbgkdffpack/ce690b9d-5521-446f-8869-87860d0ace6e:1:108305)
    at async MessagePort.<anonymous> (blob:chrome-extension://dgjhfomjieaadpoljlnidmbgkdffpack/ce690b9d-5521-446f-8869-87860d0ace6e:1:3098)
tsenart commented 5 years ago

cc @keegancsmith

lguychard commented 5 years ago

Not release-blocking for 3.6. This is not a regression introduced in 3.6. The fix will be released independently in the browser extension, and will make it into 3.7 for the native integration.

lguychard commented 4 years ago

Duplicate of #4808