sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.27k forks source link

Handle case-insensitive duplication #50403

Open peterguy opened 1 year ago

peterguy commented 1 year ago

Perforce is not case-sensitive. For example, if a "Bin" folder is created and committed in one changelist, and then someone commits a "bin" folder in another changelist, Perforce treats those as the same folder. But when p4-fusion syncs the depot, it treats those as separate folders, resulting in both "Bin" and "bin" folders showing up in Sourcegraph.

Existing issue in the p4-fusion repo.

peterguy commented 1 year ago

Estimating 1 day for research - this is probably something that needs fixing in p4-fusion. After the day of research, we might be able to estimate the effort needed to address in p4-fusion.

marcleblanc2 commented 9 months ago

Mentioned in a comment in the linked issue here, Perforce defaults to using the case sensitivity of the host OS running p4d, and can be configured with nuance. Overview here: https://portal.perforce.com/s/article/3081

It'd be great if p4-fusion, and thus Sourcegraph, had an arg / config for case sensitivity, or could extract this information from the Perforce server, ex. via p4 info or an API call