search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

PR & commit author delta #54324

Open st0nebreaker opened 1 year ago

st0nebreaker commented 1 year ago

Steps to repro:

  1. Add a global batch changes GitHub token with a different user
  2. Remove any user-level tokens
  3. Make a batch change
  4. See that the commit is authored by the correct account, but the PR is authored by the user who owns the PAT

image

Expected behavior: Batch Changes might be using the Sourcegraph users email to write the commit. Instead we should use the tokens information.

github-actions[bot] commented 1 year ago

Hey, @sourcegraph/batchers (@eseliger @courier-new @adeola-ak @BolajiOlajide @st0nebraker @malomarrec @chrispine @danielmarquespt) - we have been mentioned. Let's take a look.