search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

executors: Support for Container Lifecycle Hooks for Native k8s Executor jobs #55338

Open loujar opened 1 year ago

loujar commented 1 year ago

Problem Description

The Native Kubernetes executor solution utilizes Kubernetes Jobs to run both Batch Change and Precise indexing jobs. In Kubernetes clusters that utilize a service mesh layer such as Isitio, a networking proxy sidecar container will be injected into any pod that is created in the cluster, even if the pods are created by a "short-lived" Job controllers.

In these circumstances, the termination of the application container (i.e., the batch change or precise indexing step job container) does not automatically trigger the termination of the Istio proxy sidecar container, leaving the Pod in a "hung" state and preventing the execution of the Executor job from progressing further.

Proposed Solution

One solution to this problem would be to implement a PreStop Lifecycle Hook to send a kill signal to the Istio sidecar container after the job step execution is complete.

Related Istio issue for this topic: https://github.com/istio/istio/issues/11659

github-actions[bot] commented 1 year ago

Hey, @sourcegraph/code-search - Batch Changes has been mentioned. Let's take a look.