sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

Disable code monitors on dotcom #57539

Closed camdencheek closed 9 months ago

camdencheek commented 1 year ago

@camdencheek proposed disabling code monitors on dotcom because:

There was general agreement from engineering.

We are waiting on an email to be sent out announcing the change, then giving people a 2 week window to migrate their monitors before disabling code monitors.

camdencheek commented 11 months ago

Done by @eseliger last week

eseliger commented 11 months ago

The deprecation plan also mentioned hiding them completely on dotcom (and probably pruning the DB) which I didn't do yet - do we still plan to do that?

camdencheek commented 11 months ago

Oh shoot. I thought I had separate issues for those. I can't find them, so I'll re-open this one until that's finished.

PatMyron commented 11 months ago

The deprecation plan also mentioned hiding them completely on dotcom (and probably pruning the DB) which I didn't do yet - do we still plan to do that?

Deleting hosted code monitors with less than a month notice and no easy way to bulk export seems B2B SaaS platform unfriendly

I totally understand prioritizing platform stability through many possible options:

but hastily deleting them right around a holiday seems unnecessarily burdensome for customers with seemingly no platform stability benefit beyond simply keeping them disabled but viewable


(I've worked at places that would pay for hosted code monitoring. Pausing monitoring would leave open that possibility while deleting monitors would probably raise questions on if Sourcegraph is a reliable platform for businesses to build on)

camdencheek commented 11 months ago

Hi @PatMyron! Thanks for voicing your concerns.

a reliable platform for businesses to build on

To be clear, this change only applies to code monitors on the public sourcegraph.com instance. Code monitors are not being disabled on any instance that anyone is paying for, only on the freely-offered sourcegraph.com/search. Every user that will be affected by this was identified and notified via email a few weeks ago.

no way to bulk export

All code monitors data can be bulk exported via our GraphQL API. If you'd like help with that, I'd be happy to assist.

RE: pruning the DB, we store a lot of data about execution results that contributes significantly to DB size. I plan to delay pruning the code monitor definitions for quite a while so we can still manually export if needed.

PatMyron commented 11 months ago

All code monitors data can be bulk exported via our GraphQL API. If you'd like help with that, I'd be happy to assist.

Documentation definitely seems crucial for everyone with many code monitors to migrate: https://github.com/sourcegraph/sourcegraph/pull/58689#issuecomment-1850853919

RE: pruning the DB, we store a lot of data about execution results that contributes significantly to DB size. I plan to delay pruning the code monitor definitions for quite a while so we can still manually export if needed.

Pruning execution result data makes sense, definitely feel free 👍 Keeping the much smaller monitor definition data accessible preserves a lot of goodwill