search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.28k forks source link

Notice Banner Color Selection #59751

Closed Robertwadelinger closed 6 months ago

Robertwadelinger commented 8 months ago

Feature request description

The options for banners in global settings gives us 3 parameters to work with. It would be helpful if we could add a fourth to define the color of the banner, for instances where a given customer levees the requirement onto us.

Example: "notices": [
{
"message": "Your message here! [Include a link for more information](http://example.com).",
"location": "top",
"dismissible": true,
"color": #FF0000
}
]

(might also need a KV pair for banner text color)

Is your feature request related to a problem? If so, please describe.

May be an issue for some customers that have set standards on banner colors.

Describe alternatives you've considered.

Could change the CSS on each build, but that would not scale well.

Additional context

Code for Notice configuration is found here: doc/admin/config/settings.md

aramaraju commented 6 months ago

@cbart have we talked to Rik about this already to get this rolling?

cbart commented 6 months ago

@RXminuS can you prioritize this (even when it means we pause the diagnostics work for a little bit)?

RXminuS commented 6 months ago

Sorry wasn't aware this was something I had to look at. Will try and get my dev setup working and jump on it.

cbart commented 6 months ago

@RXminuS I see PR https://github.com/sourcegraph/sourcegraph/issues/59751 is still open but the issue is closed. Do we need to land #59751 to resolve this?

RXminuS commented 6 months ago

Yeah https://github.com/sourcegraph/sourcegraph/pull/61338 is the PR. Aravind suggested for search team and Meadah to add docs. I've added some basic docs myself but don't think they've had the time yet to look.

If you're happy with it I can quickly resolve the conflict and merge in. Then this should be resolved