sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

fix/msp/jobs: do not provision job absence alert for crons over 23h30m #64502

Closed bobheadxi closed 2 months ago

bobheadxi commented 2 months ago

Closes https://linear.app/sourcegraph/issue/CORE-237/error-creating-alertpolicy-with-an-invalid-duration-value-of-24h10m

GCP no longer allows alert policies on missing metrics for durations > 23h30m. Since the introduction of the MSP job runtime, jobs can depend on Sentry execution check-ins instead to be notified on missing job runs.

Test plan

go build -o ./sg ./dev/sg && ./sg install -f -p=false
sg msp generate -all