search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

fix(svelte): Fix production build with Bazel #64525

Closed fkling closed 3 months ago

fkling commented 3 months ago

Alternative to #64520

SvelteKit's error and redirect handling doesn't work as expected because the Bazel production build contains copies of specific classes, which breaks the instanceof checks that SvelteKit uses.

Disabling the sandbox solves that problem. See SRCH-926 for more details.

Fixes srch-926, srch-927

Test plan

Created a production bazel build and served it from a local instance. Navigated to a non-existing repository and got the expected error page.

github-actions[bot] commented 3 months ago

[!WARNING] Test ownership level below 70% on this branch.

We aim to have ~70% of Bazel test targets to help us (dev-infra) and you get insight into the impact of tests on CI times. This is a non-blocking requirement, but keeping on top of test attribution to maintain this threshold is appreciated.

See the list of tag variable names to use here, and reach out to #discuss-dev-infra if you need to add/change this list.

See an example of how to use the variables here.

fkling commented 3 months ago

Mmh, doesn't quite seem to work in CI due to this error

Error: EACCES: permission denied, open '/mnt/ephemeral/output/sourcegraph/__main__/execroot/__main__/bazel-out/k8-fastbuild/bin/client/web-sveltekit/.svelte-kit/tsconfig.json'

Not sure with which permissions those files are created.