sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.12k stars 1.29k forks source link

No syntax highlighting for shell hover contents #6771

Open christinaforney opened 4 years ago

christinaforney commented 4 years ago

When visiting https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/utils/find-rpath.sh

image

felixfbecker commented 4 years ago

This is the graceful handling :) The hover will still render, it will fall back to plain text and log a warning so we are informed a language is not supported (which I would want to keep).

The issue I see here is that we don't recognize "shell". Unless you disagree, I'll rename the issue accordingly

felixfbecker commented 4 years ago

This just needs to register the shell highlight.js highlighter under the shell name

eseliger commented 4 years ago

I think 'shell' doesn't exist in highlight.js. bash does though, so maybe the mapping is wrong?