Core Services: 3.13 Tracking Issue

tsenart commented 4 years ago

Status

This tracking issue is approved.

Availability

Period is the January 21st until February 17th. Please put in the days you won't be working and the number of working days for the period.

@keegancsmith Not working: 4th & 5th February, Availability: 18d
@kzh Availability 20d
@mrnugget - Not working: 6th & 7th February (presumably), Availability: 18d
@rvantonder 19d
@ryanslade Availability 20d
@tsenart 5d (for coding)
@unknwon Not working: Jan 24th (Chinese New Year), Availability: 19d

Planned work

@keegancsmith: 8.00d

[x] e2e: log all e2e failures into central location for triage #8026 1d
[x] gitserver: Correctly report if repos are cloning after rebalance #7970 1d 🐛🕵️
[x] download button not shown for images #7924 0.5d
[x] gitserver: implement back-off on reclone operation #7804 1d 👩🐛
[x] Test and document src-expose on ec2 with docker-compose and startup #7803 1d 👩
[x] gitserver should auto-recover from corrupt repository clones #6676 1d 👩🐛🕵️
[x] repos: Stop reading repo.enabled #3971 0.5d 🧶
[x] Support internal CA or self-signed TLS certificates for all external communication #71 2d 👩
[ ] ~zoekt: support indexing multiple branches in zoekt-archive-index~ #7930 2d 👩🕵️
[ ] ~Ref glob search perf followups~ #7642 2d 🧶
[ ] ~Code host fingerprinter~ #7464 1d 🕵️
[ ] ~Exclude directories from search results~ #6870 2d 👩
[ ] ~Gitlab OAuth certificate signed by unknown authority~ #4652 0.5d 🐛👩
[ ] ~Support SSH key credentials directly in external service configs~ #3924 2d 👩
[ ] ~docs: Ensure new arch for repo-updater is reflected in dev docs~ #3911 0.5d 🧶
[ ] ~docs: Document using an alternate clone URL for repos~ #658 0.5d 🧶

@kzh: 6.50d

[x] Add BitBucket build status support in bitbucket-server-plugin #8386 ?d 👩
[x] a8n/core: Support updating changesets on BitbucketServer #7762 1d 🛠️
[x] a8n: Move "default branch" check to execution of CampaignJob #7725 2d 🛠️
[x] a8n/core: Extend CreateCampaignInput to accept Branch and persist it #7687 2d 🛠️
[x] Password-reset link not rendered for non-admin users #7520 0.5d 🐛
[x] Error fetching commit author info from GraphQL API #5335 1d 👩🐛
[ ] ~Simplify Bitbucket Server plugin interaction with Sourcegraph~ #7824 3d
[ ] ~Forbidden - CSRF token invalid~ #7368 2d 🐛
[ ] ~Address repohascommitafter search filter performance bottleneck~ #6745 0.5d

@mrnugget: 10.00d

[x] a8n: failed creating PRs because 'assignee' doesn't exist #8113 1d 🐛
[x] Creating a manual campaign -> unexpected draft mode #8009 ?d 👩
[x] a8n: Updating partially published Campaigns is not supported #7915 2d 🐛
[x] Automation should never miss search results #7861 3d 🐛🧶
[x] a8n: Finish implementation of src actions exec #7850 3d 🛠️
[x] Send pings about Automation usage to Sourcegraph #7711 1d
[ ] ~Write C# LSIF indexer~ #7760 ?d 🛠️
[x] ~a8n Spike: Add ability to "stack diffs" (RFC 92)~ #7721 3d 🛠️

@rvantonder: 6.00d

[x] Trailing backslash at end of expression: `` when searching for valid regexp #7604 1d 🐛👩
[x] Enforce warnings for unsupported parameters and filters in structural search #7293 1d 🧶
[x] Backend returns invalid filter chip with space "lang:ignore list" #6498 2d 👩🐛
[x] Impossible to search for colons in literal search #6490 2d 🐛
[x] ~search: design proposals for AND / OR / NOT expressions~ #8346 4d
[ ] ~Extract and dump type information for Dart LSIF~ #7908 4d 🛠️
[ ] ~search: Implement AND / OR / NOT for file contents~ #7823 ?d
[ ] ~search filter archived/fork "yes/no/only" values are confusing~ #7003 4d 👩🛠️

@ryanslade: 8.00d

[x] a8n: exposed token in the error message if create campaign failed #8105 ?d 🐛
[x] sourcegraph/security-issues #60 ?d 🐛🔒
[x] Redact GitLab access token from error log message #8078 ?d 🐛
[x] Add setting to enable read-only mode for automation for all Sourcegraph users #8013 ?d 👩
[x] a8n/auth: Regex search/replace doesn't work in private repos #7914 1d 🐛
[x] Remove published_at fields from Campaign and ChangesetJob #7782 2d 🧶
[x] a8n/core: GraphQL API for an extended campaign list view #7553 2d 🛠️
[x] a8n/core: Expose labels of all changesets in campaign in GraphQL API #7549 1d
[x] a8n/core: Expose CI status on changesets #7093 2d 🛠️
[ ] ~a8n/core: Extend GraphQL API to include participant users involved in the campaign~ #7552 1d 🛠️
[ ] ~a8n/core: Expose comments of all changesets in campaign in GraphQL API~ #7548 2d 🛠️
[ ] ~Diagnose and fix slow /.api/registry/extensions endpoint~ #7544 1d 🧶
[ ] ~a8n: Heuristic syncing of Changesets and ChangesetEvents~ #6388 3d 🧶

@tsenart: 3.50d

[x] Use basic auth instead of query params for auth in github-proxy #8310 0.5d 🧶
[ ] Core Services: 3.13 Tracking Issue #7719 ?d
[x] Prevent upgrading more than one minor version at a time #7702 1d 🐛
[x] Redis AOF file grows unbounded due to frequent container restarts #3300 2d
[x] redis: Log spam warning when redis is loading the dataset in memory #2904 ?d 🐛👩
[ ] ~Reject invalid externalURL with non-/ path~ #7884 0.5d 🐛

@unknwon: 16.00d

[x] External services documentation needs to be updated #8288 0.5d
[x] Make read:org permissions optional / dependent upon whether allowOrgs is specified #8163 1d 👩
[x] sourcegraph/security-issues #61 0.5d 👩🔒
[x] Bitbucket Cloud external service doesn't respect custom URLs #7990 1d 👩
[x] authz code logs warnings about Redis returning nil values #7912 0.5d 🐛
[x] RFC 40: Move call to the Authz methods into application layer #7878 1d 🧶
[x] sourcegraph/security-issues #55 1d 🔒
[x] RFC 40: Add unit tests for GraphQL APIs #7748 1d 🧶
[x] sourcegraph/security-issues #54 1d 🔒
[x] Enable HTTP Strict Transport Security (HSTS) on sourcegraph.com (and all subdomains) #7660 0.5d 🔒
[x] It is not clear how to configure Sourcegraph to just access public repositories #7587 0.5d 🐛
[x] Enforce minimum password requirements #7521 0.5d 🔒
[x] RFC 40: Handle user deletion #7302 1d
[x] Match highlight at the end of a long result snippet freezes browser tab #6489 1d 🐛
[x] Querying repository by name with github.com prefix always returns empty string for name #5125 1.5d 🐛
[x] unused site setting git.cloneURLToRepositoryName #3768 0.5d 🧶
[x] postgresql: (Auto)tune DB pool sizes based on max_connections #3473 3d 👩
[ ] ~Make new pricing tiers reflected in feature access~ #7927 1d 🐛
[x] ~RFC 40: Add Prometheus metrics~ #7827 1d 🛠️
[x] ~sourcegraph/security-issues~ #53 ?d 🔒
[ ] ~Auth: explicit session invalidation~ #1126 2d 🔒

Legend

👩 Customer issue
🐛 Bug
🧶 Technical debt
🛠️ Roadmap
🕵️ Spike
🔒 Security issue

unknwon commented 4 years ago

W05 Summary

[x] Finish 2020 Q1 review cycle
[x] Address feedback and get approval for RFC 109: More friendly onboarding process for user permissions
- Implemented in #8356
[x] Match highlight at the end of a long result snippet freezes browser tab #6489
[x] Draft and get approved for RFC 110: Unified store layer for permissions
Draft RFC 113: Move GitLab permissions syncing to background in repo-updater
- Needs revise and live discussion
MISC: #8381

W06 Plan [2020-02-17]

Revise and get approval for RFC 113: Move GitLab permissions syncing to background in repo-updater
Tackle customer issue Can not add new user to Sourcegraph by JumpCloud SAML problem
Spike: add cross-repo hover tips to lsif-go

mrnugget commented 4 years ago

W05 Recap

I didn't make a lot of progress on investigating remote code-execution in src CLI (#7723), because I was in London for three days (including two travel days) and other higher-priority items came up.

But I did manage to:

Fix a bug that blocked one of our Automation beta customers and shipped a patch release that includes the fix to them: https://github.com/sourcegraph/sourcegraph/pull/8379
Implemented the sending of Automation usage pings #8374
Fix a bug that caused the reported state of changesets that are being published to be wrong #8403
Documented the -branch flag in src #8421
Actually refactored some TypeScript with the help of @eseliger #8425
Various fixes in src-cli: https://github.com/sourcegraph/src-cli/pull/104, https://github.com/sourcegraph/src-cli/pull/116, https://github.com/sourcegraph/src-cli/pull/120, https://github.com/sourcegraph/src-cli/pull/121, https://github.com/sourcegraph/src-cli/pull/126

W06 Plan [2020-02-17]

It's release week so I anticipate some last-minute fixes and polish work.

I also plan on planning the next iteration, which I suspect will for me focus on remote code-execution with src CLI. I want to finally make progress on that.

Besides that I also want to fix some action exec related issues in src CLI: https://github.com/sourcegraph/src-cli/issues?q=is%3Aissue+is%3Aopen+label%3Aaction-exec Help wanted! :)

ryanslade commented 4 years ago

W05 Summary

Was in London from Monday to Thursday

Completed the following:

Build status now displaying for both GitHub and Bitbucket
Decoupled changeset syncing from repo syncing

W06 Plan

Add CheckRun support for GitHub, we currently only support CheckSuites
Start work on heuristic syncing, which I assume will become my focus in the next iteration
Help out with any last minute changes needed during release week

keegancsmith commented 4 years ago

W04 and W05 Summary

Been an unusual two weeks. Travel and family in W04 reduced my planned output, and the Core Services meetup in W05 also reduced my planned output. In the midst of that I have switched to focussing on some important issues related to customers with some fun scale requirements. That work is still ongoing.

W06 Plan

I still need to take a proper step back and replan the work assigned to me. But top of mind for me is sourcegraph/customer#19 and sourcegraph/customer#18. I also still need to submit lattice :O. A normal week for me otherwise, so I expect to tackle all of that and have a well planned W07.

kzh commented 4 years ago

W05 Summary

Finished Lattice reviews
Opened PR for bitbucketserver: clean up plugin configuration #8396
Document updating/drafting campaign workflow #8436
Brainstormed on #6745 Address repohascommitafter search filter performance bottleneck and worked on Add BitBucket build status support in bitbucket-server-plugin #8386
Merged graphql: lazy load commit information in search results #8343

W06 Plan

Open PR for #6745, #8386, and write extensive BBS plugin docs for sourcegraph/customer#18.

tsenart commented 4 years ago

Thanks everyone for the awesome work this iteration! Closing this issue. Next tracking issue is here: #8552

sourcegraph / sourcegraph-public-snapshot