sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.11k stars 1.29k forks source link

Scala code intelligence #8

Closed beyang closed 5 years ago

beyang commented 7 years ago

Support Scala on Sourcegraph

sqs commented 6 years ago

Update: https://twitter.com/avibryant/status/1047181708687265792

I will be talking with Olafur and Eugene in the next week or so about integrating the existing Scala lang server into Sourcegraph.

mwz commented 5 years ago

Goto definition feature was recently implemented in metals, perhaps it should now be possible to make a start on this?

chrismwendt commented 5 years ago

Sweet, would you (or someone you know) be interested in making it happen? Sourcegraph extensions make it easy to add language support to Sourcegraph (e.g. Go). We're happy to help out with support and funding!

chrismwendt commented 5 years ago

Scala code intelligence has been added in Sourcegraph 3.0 :tada:

https://about.sourcegraph.com/blog/sourcegraph-3.0#code-intelligence-for-all-languages

Try it out on Sourcegraph.com:

image

sslavian812 commented 5 years ago

Is this Scala-langserver open-sourced already?

sqs commented 5 years ago

Yes, the language server discussed above is https://github.com/scalameta/metals.

ittaiz commented 5 years ago

Just to make sure I understand- the scala support is text based and without a language server protocol, right? Just couldn’t be sure from the docs

chrismwendt commented 5 years ago

@ittaiz Correct, Scala support is based on ctags + text search (as is all out-of-the-box code intelligence for Sourcegraph).

Which docs page did you look at? I'd like to improve these.

ittaiz commented 5 years ago

I was here which does say it's text based but doesn't explicitly says it's not LSP based. I wasn't sure if the omission indeed means it's not supported because this issue made me think it might have been implemented with it due to above comments.