Closed tsenart closed 4 years ago
@sourcegraph/core-services: Please propose additional work for the iteration if it hasn't yet been milestoned and labeled accordingly.
W06 Summary
W07 Plan
private
column from the metadata
src action exec
https://github.com/sourcegraph/src-cli/pull/128src-cli
(https://github.com/sourcegraph/src-cli/pull/132, https://github.com/sourcegraph/src-cli/pull/133, https://github.com/sourcegraph/src-cli/pull/135, https://github.com/sourcegraph/src-cli/pull/136, https://github.com/sourcegraph/src-cli/pull/138)a8n
to campaigns
in the codebase!src-cli
After talking with @christinaforney and @eseliger on Friday about the future of src-cli
, I will start to
src actions
Point (b) is the result of learning from the prototype in https://github.com/sourcegraph/src-cli/pull/128. We realized that it does not provide enough value (compared to ssh & tmux & src action exec
on a big machine) to warrant the effort to build it out proper.
A multi-agent model, where agents pull work from and report progress to Sourcegraph, does provide more value and also moves us in the direction we want to head in anyway (where we can add a web UI to start/watch actions). More details going to be discussed in today's Campaigns sync.
Besides that I'm going to:
W06 Summary
W07 Plan
@tsenart my current work items is stable and what I've settled on for this iteration.
Thanks @rvantonder. @keegancsmith, @mrnugget, @ryanslade, @unknwon: Is your planned work ready? Please let me know as I want to finalise the tracking issue today.
@tsenart I've finished arranging work items for this iteration.
@tsenart Yes, mine is stable, even though it's hard to put concrete estimates on it, since I suspect that some things will change in the course of the iteration (since we're trying out and prototyping a lot of things with src
CLI)
My work will be in flux all iteration, as I triage/investigate the current and incoming customer issues. The things that are not customer related are minor documentation/debt that I will tackle and can be regarded as stable.
@tsenart My work is stable unless I need to take over anything from Kevin
@nicksnyder, @christinaforney: The tracking issue is ready for your review.
LGTM
nit: there are some references to a8n :)
question: This week is week 7? Should reset to 0 for new release cycle right?
question: This week is week 7? Should reset to 0 for new release cycle right?
Are you referring to the weekly status updates? We haven't reset before, it's always been the week of the year (starting at 0), like we use in Company Meeting.
W07 Summary
Focused almost singularly on the AND/OR query parser. This is, in some ways, the most important part to get right and I feel good about the direction and implementation for building things out.
lsif-java
and got some hints about fixing known issues to improve the quality: https://github.com/sourcegraph/lsif-java/issues/17W08 Plan
Integrate AND/OR parser with what we currently use for our parser scanner, then migrate our existing tests. I made partial progress on this last week.
Mid-week, I expect to have prototype support/translate AND/OR queries for content search. After that, I expect to polish and thoroughly test for the rest of the week
Set aside 0.5d to 1d to investigate #6745
(Re)-prioritize search latency PR. Dependent on #8423 which isn't landed yet, but I can still make progress without it.
I also want to find some more structural search use cases and promote those (tweets, docs), possibly related to customers. The initial blog post response is cool, but I'd like a rolling stream of more examples.
authz.PermsSyncer
#8376
authz.PermsSyncer
#8376 0.5dauthz.PermsStore.SetUserPermissions
method #8607 0.5dsrc
CLI:
src
CLI UX, probably moving more to Sourcegraph itselfFirst week of customer support. Ended up fixing a few issues, while filing a few others. It has been great to be directly interacting with customers to get a feeling for common issues customers run into. More importantly it improves my intuitions around projects we can do to improve our customer experience.
I've been focussed on filing issues rather than fixing them. Additionally been thinking of projects we can do. This will continue, and I will continue to resist the urge to jump into code :)
More of the same. It feels like the load will be less this week, so I will tackle one of the projects I think will help with customers / already planned work.
Change of plans, I won't be attending ScaleConf so I've got an extra two days of availability.
authz.PermsStore.SetUserPermissions
method #8607provider
column nullable for perms table #8608authz.PermsSyncer
#8376
authz.PermsScheduler
#8708
My theme this week is to ship RFC 113
authz.PermsSyncer
2dI spent the majority of the week helping @eseliger testing and debugging the campaign he created for https://github.com/sourcegraph/customer/issues/13 That resulted in a lot of fixes and issues:
That combined nicely with documenting the bitbucket-server-plugin
for https://github.com/sourcegraph/customer/issues/18 and improving the Campaigns documentation in general:
The rest of the week was spent on interviews, hacking on our docs, trying to get IntelliJ to run bitbucket-server-plugin
, adding a mission/vision statement for Campaigns (https://github.com/sourcegraph/about/pull/623 and https://github.com/sourcegraph/about/pull/628)
Besides that: I want to try to get some improvements to our docs merged, interviews, getting back into src
CLI improvements, hopefully start to pick up remote-code execution prototype.
W08 Summary
and
/or
queries so I have a clear idea how for breaking down the implementation/testing into subtasks. Example clip on slack.W09 Plan
and
/or
query work. I will broadly be tackling tasks around any of:
More customer support. Attended bits of a conference on Thursday and Friday and chatted to a few people about Sourcegraph. Was otherwise a bit of a low productivity week for me (sleep :/), should pick the pace back up this week.
My main priority is still customer support. But any time not spent doing customer support/code reviews will be spent on helping out on permissions background syncer. We want to ensure it is ready by branch cut, and its at a point where we can start sharing the remaining work.
authz.PermsSyncer
authz.PermsSyncer
0.5dPermsStore.AuthzroizeRepos
return a third argument to indicate if the result is complete 0.5dW09 Summary
I spent 80% of this week on customer-related search functionality. The highlight is that turning off search for forks by default caused unexpected and poor UX when searching an existing repo. I spent time on a solution for that (thanks @keegancsmith for suggesting a much easier approach than fiddling with the webapp). That needed careful testing, and I also discovered a discrepancy in how this is dealt with in sourcegraph.com versus other deploys due inconsistency in handling type:repo
in queries. Basically: a lot of tricky cases and unexpected UX things to consider in search, and expensive to fix, test, and change comprehensively. In addition, the following happened:
@commit
part matches HEAD (likely to be an improvement for monorepo customers when we autofill queries with @commit
)concat
operator to the new and
/or
parser.repohascommitafter
perf in #6745. This is important, but de-prioritized due to the other search issues needing more time.W10 Plan
and
/or
queries.W09 Summary
W10 Plan
I added documentation for the Bitbucket Server plugin and tweaked our docs a tiny bit while working on them (added global breadcrumbs, made headers consistent, etc.)
Also took some time to try to improve our local dev workflow and ended up improving our watch-recompile scripts in a way that stops all Go services being restarted, even though they didn't change.
After @eseliger uncovered more bugs in our webhooks/events-based-changeset-state implementations I spent the latter part of the week focused on fixing those and improving them.
This week is going to be bumpy. Germany is in nearly full-on Corona mode: borders are closed, events are cancelled and, relevant to this thread, daycare is closed for the next 5 weeks. That means my wife and I will alternate watching our daughter throughout the day. I hope I can make it to all meetings on time and get some stuff done, but at this point I'd rather offer a disclaimer than make promises.
Well, at least the weather is nice.
Now, if I do manage to get things done, I want to:
src action exec
but not have merged/close changesets disappear), I just need to think through the ramifications.The last point is also what I think we should focus on in the next iteration regarding campaigns.
Usual focus on customer issues. Several minor src-expose changes after feedback from a customer. Did a patch release for 3.12.10 and 3.13.2 containing useful fixes but most importantly a fix for breaking old installations of bitbucket. Lots of time spent on Zoekt slowness. Ongoing. https://github.com/sourcegraph/sourcegraph/issues/9001
Zoekt slowness https://github.com/sourcegraph/sourcegraph/issues/9001 and start planning for 3.15. Schools are closing down here so will be juggling childcare with my wife (who isn't always remote yet). As such I am in a similar boat as others with respect to focus time.
Dear all,
This is your release captain speaking. πππ
Branch cut for the 3.14 release is scheduled for tomorrow.
Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!
Thank you
Status
This tracking issue is active.
Availability
Period is the February 21st until March 17th. Please put in the days you won't be working and the number of working days for the period.
Planned work
@keegancsmith: 0.50d
@mrnugget: 3.00d
@rvantonder: 7.00d
@ryanslade: 10.50d
@tsenart: 0.00d
PermsFetcher
interface for Bitbucket Server authz provider #8891 ?d@unknwon: 9.50d
PermsFetcher
interface for GitHub authz provider~ #8890 ?dauthz.PermsScheduler
#8708 1d π οΈauthzFilter
to adopt new ways to check permissions #8630 1d π οΈPermsSyncer
#8612 0.5d π οΈprovider
column nullable for perms table #8608 0.5d π οΈauthz.PermsStore.SetUserPermissions
method #8607 0.5d π οΈPermsFetcher
interface for GitLab authz provider #8492 1d π οΈauthz.PermsSyncer
#8376 2d π οΈ@uwedeportivo: 4.00d
Legend