search

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody
https://sourcegraph.com
Other
10.1k stars 1.27k forks source link

Core Services: 3.15 Tracking Issue #9116

Closed tsenart closed 4 years ago

tsenart commented 4 years ago

Status

This tracking issue is WIP.

Availability

Period is the March 21st until April 18th. Please put in the days you won't be working and the number of working days for the period.

Planned work

@keegancsmith: 6.00d

@mrnugget: 9.00d

@rvantonder: 16.50d

@ryanslade: 9.50d

@sqs

@tsenart

@unknwon: 6.50d

@uwedeportivo

Legend

keegancsmith commented 4 years ago

My work for 3.15 looks good. I'll still be focussed on customer issues. Non-customer related issues all have the theme of finishing up things I started/wanted to do earlier this year:

Note: I am over my availability. However, my availability is just a very conservative estimate and I am hoping all the docs tasks can be done in a day. I think the task that will most likely slip is the gitserver debt (maybe should just remove from the plan now?)

mrnugget commented 4 years ago

My planned work also looks good. Some of the issues I estimated conservatively, but considering that the next few weeks will be bumpy due to childcare and irregular schedule, I think it can work.

tsenart commented 4 years ago

I think the task that will most likely slip is the gitserver debt (maybe should just remove from the plan now?)

@keegancsmith: +1

unknwon commented 4 years ago

My planned items are settled.

rvantonder commented 4 years ago

I've set my work items. I'm over considering I should allocate customer-related things that crop up, but there's some flexibility taking 3 to 4 days off by doing tasks in #9171, #9173, #9174 partially. I prefer having a complete picture rather than leave things off to get under the quota.

tsenart commented 4 years ago

@ryanslade: Any update?

ryanslade commented 4 years ago

@ryanslade: Any update?

I was waiting for RFC 132 to stabilise. I've pulled issues out of that now and it looks like I'm only about 50% utilised this iteration. I assume there might be customer issues coming through but I'd like to get closer to 75% so any issue suggestions welcome.

mrnugget commented 4 years ago

@ryanslade I'm assigned to these, but if you want to take them on, I'd be happy:

They're all pretty self-contained and rather small (except the last one, which doesn't have a proposed solution yet).

rvantonder commented 4 years ago

W09 Summary

Major work this week was figuring out and implementing a code path to support and/or queries while keeping existing parsing and logic as a fallback. The goal is to eventually migrate the current query handling and the new code needs to make that possible. That process and other items was also part of my planning this week.

Other than that,

W10 Plan

This week I'll implement the functionality to evaluate and/or queries. I prototyped/hacked on this a couple of weeks ago. As a first implementation, the approach will implement intersection/union operations on top of search queries. After that, I'll focus on bringing and/or query validation in line with our current validation steps (because I'll first add and/or query evaluation without doing much validation/user-facing concerns, since the former is more important).

mrnugget commented 4 years ago

Last week

The week wasn't as productive as I would've liked, what with the global pandemic and daycares closed and things like that.

But I still managed to finish planning, clean up a lot of now-unneeded code and started to make progress on https://github.com/sourcegraph/sourcegraph/issues/9106

This week

I'm really looking foward to finishing https://github.com/sourcegraph/sourcegraph/issues/9106. "Renaming" might sound trivial, but it's removing a huge cognitive load for users and/or developers. Besides that I want to make progress on a lot of the other bug-fix/tune tickets we have for Campaigns.

Regarding productivity: I now have fixed "childcare" time slots, so if everything goes according to plan, I should be more productive the rest of the time.

unknwon commented 4 years ago

W10 Summary

Mainly focused on shipping and e2e testing of background permissions syncing for GitLab and Bitbucket Server.

W11 Plan [2020-03-23]

ryanslade commented 4 years ago

W10 Summary

Fixed some campaign metadata bugs and improved page load time on the campaign page from around 400ms to 250ms (on my laptop). I think we have more room for improvement so would be nice to take another look at some point.

Otherwise spent a lot of time on RFC 132 (still under review)

W11 Plan

Hopefully finalise RFC 132 and start work on its implementation

imtommyroberts commented 4 years ago

If you feel as though some input from UX on any of your planned work would be helpful please let me know! No need for design files etc, we can just set up a call and walk me through what it is that you've worked on, and I can give feedback as needed.

unknwon commented 4 years ago

W11 Summary

W12 Plan [2020-03-30]

rvantonder commented 4 years ago

W11 Summary

Implemented a basic evaluator for and/or search queries. I added a flag that activates the (still in development) code path. Things are on track.

W12 Plan

I'll be refining query parsing and parentheses handling for each of literal, regex, and structural search on the new and/or code path (#9170). I'll be working on getting feature parity with existing assumptions on search patterns for each kind of search on the new and/or code path (#9171).

mrnugget commented 4 years ago

Last week

Again, not the most productive week, due to childcare duties, an irregular schedule and multiple interviews and meetings in the time I had left.

I did manage to finish The Big Rename of Campaigns-related entities, write tests, add documentation, start RFC 135 with @eseliger.

This week

Hopefully I'll be able to finish up multiple of the smaller tickets assigned to me and to fix some of the things that @unknwon ran into when trying Campaigns since I deem those to be higher priority than a lot of other things I had planned.

I'm also realizing that I was too optimistic when planning this iteration, I probably won't be able to finish all my tickets.

Especially not since I'll be on vacation next week.

ryanslade commented 4 years ago

W11 Summary

W12 Plan

I'll start working through the tickets to implement RFC 132

keegancsmith commented 4 years ago

Last week

Mixed productivity week due to South Africa going into lockdown. But the time I did have I investigated some low hanging fruit w.r.t. performance on Sourcegraph.com. I added some metrics to validate the work I'll ship this week around fixing it. Additionally I dived very deep into git protocol v2 since it is now the default in git. It was technically very interesting and gratifying. Expect a nice write up (and a perf increase in our use of ls-remote).

Overall I didn't follow the planned work I have, and just let my curiosity drive my work. I highly enjoyed it and will do it again this week (while making time for important planned work).

This week

I have traded internet for child-care. Internet is too bad for VC (better by Wednesday hopefully), but I have childcare now. So my plan is to dive into performance issues on Sourcegraph.com. I'll also spend a day doing docs (large portion of my planned work).

keegancsmith commented 4 years ago

Last week

Was a productive week. Shipped some performance improvements for the raw endpoint. Details here (with graph) https://github.com/sourcegraph/sourcegraph/issues/9372#issuecomment-608367909. Also helped fix a few ops issues we had on Sourcegraph.com: Downtime due to pgsql and disk permissions; lang-go OOMing which is still ongoing.

I forgot to mention this last week, but also cleaned up our observability a bunch in production. Details here https://sourcegraph.slack.com/archives/C89KCDK5J/p1584690177068800

This week

Main goal is to ensure all docs related tasks are done. Other theme will be some src-expose work: adding some tests, fixing a bug for a customer and merging into src-cli. Otherwise I will continue to look into sourcegraph.com since it has been so fruitful for guiding work.

unknwon commented 4 years ago

Last week

W13 Plan [2020-04-06]

rvantonder commented 4 years ago

W12 Summary

W13 Plan

ryanslade commented 4 years ago

Week 12

Refactored the changeset syncer so that we have one syncer per external service. This took longer than expected because each changeset can belong to multiple external services so we needed to come up with a way to pick just one service given a changeset. This is all needed for when we add rate limiter config to external services.

This Week

Add configurable rate limters to Bitbucket Server / Cloud, GitHub and GitLab

mrnugget commented 4 years ago

Last week

Vacation.

This week

Besides work ingon the tickets that are assigned to me, I want to invest some more time into the Campaign docs, since those are missing some high-level explanations that new users are looking for (and that have become self-evident to us developers). And then we also need to plan the next release.

unknwon commented 4 years ago

Last week

Had a tough week with extremely poor sleep quality and low productivity, mostly reading RFCs and reviewing PRs.

Updated docs and tests for GitHub background permissions syncing, also started a conversation with distribution team about a token access problem, i.e. how to better communicate with customers. Little progress on the permissions UI work, most likely won't be able to catch the branch cut.

W14 Plan [2020-04-13]

rvantonder commented 4 years ago

Last week

Lots of work on getting and/or queries ready to ship, especially around accommodating tricky queries (e.g., containing dangling parens, like foo( and bar() and expression grouping, see #9761, #9762.

This week

keegancsmith commented 4 years ago

Last week

Main goal was to do all doc related tasks, and I did! I missed one, but will do that soon (so counting it as a win). The mix of forgetting about Easter Weekend and docs taking most of my time meant I didn't get to merging src-expose into src-cli.

This week

Plan 3.16. Finish up external communication work. Likely start work on indexing multiple branches again.

ryanslade commented 4 years ago

Last Week

Adding configurable rate limits to a number of sources and integrating them into the changeset syncer.

This week

Adding instrumentation to the rate limiter / syncer and integrating the state of the rate limiter into scheduler logic. Currently we keep the existing schedule but wait for rate limit availability rather than using it as an input to the scheduler.

uwedeportivo commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.15 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you