web: 3.15 tracking issue

lguychard commented 4 years ago

Planned work

@Unassigned

[x] web: 3.15 tracking issue #9159

@attfarhan: 6.00d

[x] Icon toggles have misaligned highlights #9671 0.5d 🐛
[x] Onboarding changes for 3.15 #9240 2d
[x] multiple valid values for discrete filters #8790 0.5d
[x] Improve onboarding experience #8584
[x] Interactive mode filters have trouble with double quotes #8418 1.5d 🐛
[x] Go-to-definition does not select new file in tree #4710 1.5d 🐛
[x] Onboarding updates #9628 :shipit:

@eseliger: 6.00d

[x] Remove feature flag for campaigns in navbar #9555 0.5d
[x] List styling is not consistent across features #9268 0.5d
[x] Campaigns splash screen #9140 1.5d
[x] Make campaign.description nullable in GQL #9034 0.5d 🧶
[x] Make it clearer how to go from list of changesets to changeset on codehost #8149 0.5d
[x] Sprinkle CLI instructions into the campaigns UI #8070 1.5d
[x] a8n: Implement code intelligence for external changesets #6749 1d
[ ] ~Bitbucket Server webhooks miss needs work => unapproved~ #9139 2d 🐛
[ ] ~More thorough E2E tests for campaigns~ #9138 2d
[ ] ~Provide an easier way to add changesets to manual campaigns~ #8766 2d
[ ] ~Campaign progress is "Creating changes" even when updating a Campaign~ #8438 0.5d 🐛

@felixfbecker: 14.00d

[x] Diff header on GitHub is broken in 2 lines #9675 🐛
[x] Misaligned breadcrumb text in diff view #9601 0.5d 🐛
- [x] Fix nav item not being centered #9741 :shipit:🐛
[x] Focus rings barely visible #9493 1d 🐛
[x] Improving extensions toolbar on code hosts and Sourcegraph #9462
- [x] Dont break GitHub file toolbar #9517 :shipit:
- [x] Fix action bar design #9503 :shipit:
[x] Sourcegraph button on repository page does not retain selected branch #9414 1d 🐛
- [x] Respect the revision when jumping to Sourcegraph from GitHub #9520 :shipit:🐛
[x] Find references button doesn't show if token is hovered before provider is registered #9350 3d 🐛
[x] Loader is never shown if hover provider is called before providers are registered #9349 🐛
[ ] ☂️ Code intel paper cuts #9346
[x] Add sign in buttons on PR views too #9276 2d 👩
- [x] Display sign in buttons in code view toolbar #9275 :shipit:👩
[x] Native integrations: show a UI hint that the user should log in to Sourcegraph #8758 3d 👩
- [x] Native integrations auth flow #9112 :shipit:
[x] Browser extension silently breaks instead of saying "repo not on your sourcegraph instance" #7599 0.5d 🐛
- [x] Fix error handling #9699 :shipit:
[x] Function of extension-contributed buttons is not clear #5488 🐛
[x] Too many Sourcegraph extensions wreck GitHub toolbar UI #4480 1d 🐛
- [x] Dont break GitHub file toolbar #9517 :shipit:
[x] Browser extension should gracefully handle auth proxies signing users out after inactivity #3440 2d 🐛
[x] Browser extension stops working when SAML auth token expires #545
[ ] ~Incorrect z-indexes in UI~ #8380 1d 🐛
[x] Fix url being passed as ariaLabel #9755 :shipit:🐛
[x] Exclude GitHub tree pages from CSS selector #9714 :shipit:🐛

@lguychard: 3.00d

[x] Search pattern is duplicated when using a toggle after switching search modes #9407 0.5d 🐛
[x] Search bar looses focus after whole page is loaded #9124 🐛
[x] Search bar no longer updating to show current repo with smartSearchField turned on #8839 0.5d 🐛
[x] Suggestion icons hard to see in light theme #8764 0.5d 🐛
[x] Search bar and directory page have different search bars #8752 0.5d 🐛
[x] MonacoQueryInput theme is broken on pages that have another Monaco editor #7697 1d 🐛
[x] Enable Git Extras by Default #3501
[ ] ~Intermediate plain text search bar should use same font as Monaco editor~ #9499 0.5d
[ ] ~Search bar steals "Cmd+L" keybinding~ #9125 🐛
[ ] ~New search autocomplete yields no results in this particular case~ #8749
[ ] ~Missing space when inserting new filter~ #8740 0.5d 🐛
[ ] ~Cursor is put at the beginning of search field after submitting (instead of staying at end)~ #8731 0.5d 🐛
[ ] ~Branch/commit/tag selector dropdown is slow on giant monorepo (100K+ branches)~ #8594
[ ] ~MonacoQueryInput does not shrink when the window is resized.~ #7692 1d 🐛
[ ] ~Clicking "Show more" at end of a result set does not jump you back to the top of the page~ #7024 🐛
[x] Remove scoped search bar from TreePage, scope global query to the current tree or file instead #9225 :shipit:
[x] Use IntersectionObserver in trackViews() #5541 :shipit:

@mrnugget: 0.50d

[x] Updating a closed campaign with N already merged changesets creates N new changesets #9395 0.5d 🐛

Legend

👩 Customer issue
🐛 Bug
🧶 Technical debt
🛠️ Roadmap
🕵️ Spike
🔒 Security issue
:shipit: Pull Request

tsenart commented 4 years ago

@lguychard: I added the necessary tags in the issue body for the automation to work.

lguychard commented 4 years ago

W10 summary

Helped debug Bitbucket Server native integration for https://app.hubspot.com/contacts/2762526/company/1767812339
Fixed display of activation dropdown confetti https://github.com/sourcegraph/sourcegraph/pull/9077
Some backlog triage
Fixed debouncing of smart search suggestions https://github.com/sourcegraph/sourcegraph/pull/9197
Fixed some UI glitches in the site admin onboarding widget https://github.com/sourcegraph/sourcegraph/pull/9203
PRs in progress:
- Removing scoped search bar from TreePage and replacing it with a button https://github.com/sourcegraph/sourcegraph/pull/9225 (or removing it altogether, see https://github.com/sourcegraph/sourcegraph/pull/9225#discussion_r396337563)
- Removing global queryUpdates subject https://github.com/sourcegraph/sourcegraph/pull/9233
- Unifying Monaco themes https://github.com/sourcegraph/sourcegraph/pull/9237

W11 Plan

Finalizing this tracking issue
Wrap up outstanding smart search bugs.

attfarhan commented 4 years ago

W11 Summary

Fix quotes not being handled in interactive mode https://github.com/sourcegraph/sourcegraph/pull/9315
Graded two coding exercises
Opened PR to handle other yes/no/only values https://github.com/sourcegraph/sourcegraph/pulls
Help Ryan with reorganizing blog posts in website

W12 Plan

Finish helping Ryan with reorganizing blog posts in website
Grade coding exercise
Onboarding UI updates https://github.com/sourcegraph/sourcegraph/issues/9240
Fix file tree not updating on code intel actions https://github.com/sourcegraph/sourcegraph/issues/4710
Fix interactive mode doesn't handle suggestions properly https://github.com/sourcegraph/sourcegraph/issues/9378

lguychard commented 4 years ago

W11 Summary

Fix sourcegraph.configuration in the extension API https://github.com/sourcegraph/sourcegraph/pull/9311
In progress:
- Remove scoped search bar from tree page, scope global query to the current tree/file instead https://github.com/sourcegraph/sourcegraph/pull/9225
- Smart search: place cursor at the end of the field https://github.com/sourcegraph/sourcegraph/pull/9388
- Smart search: fix suggestions in light theme https://github.com/sourcegraph/sourcegraph/pull/9389

W12 plan

I'd like to start thinking about what a project around extensions improvements would look like. Regrouping relevant issues & writing down thoughts in a doc / RFC.

felixfbecker commented 4 years ago

W11 Summary

Interviews
Improved e2e docs and fix e2e bugs
Display sign in buttons in toolbar https://github.com/sourcegraph/sourcegraph/pull/9275
Debt: Convert components to hooks
Improve browser extension options menu https://github.com/sourcegraph/sourcegraph/pull/9281
Discuss how to improve hover UX with Loic and Tommy
Fix flaky e2e test https://github.com/sourcegraph/sourcegraph/pull/9232
Fix user-reported bug https://github.com/sourcegraph/sourcegraph/pull/9313

W12 Summary

Plan https://github.com/sourcegraph/sourcegraph/issues/4480 with Tommy
Interviews
TBD

eseliger commented 4 years ago

W11 summary

Interviews and code screens
Started on RFC 135
Lot's of debt work on campaigns and small bug fixes after the big rename

W12 plan

Work on RFC 135
Campaigns splash screens
Squeeze in more campaign enhancements if time allows
One interview so far

lguychard commented 4 years ago

W12 Summary

Merged some fixes on the smart search field: https://github.com/sourcegraph/sourcegraph/pull/9408, https://github.com/sourcegraph/sourcegraph/pull/9389
Did some cleanup in the webapp search code: https://github.com/sourcegraph/sourcegraph/pull/9409, https://github.com/sourcegraph/sourcegraph/pull/9412
Tweaked our job requirements and interview documentation: https://github.com/sourcegraph/careers/pull/82, https://github.com/sourcegraph/careers/pull/83
Enabled git-extras by default https://github.com/sourcegraph/sourcegraph/pull/9540
Tweaked hover tooltip loading time as discussed in the previous web sync: https://github.com/sourcegraph/codeintellify/pull/244
Prototyped UI integration tests following RFC 137: https://github.com/sourcegraph/sourcegraph/pull/9591

W13 Plan

Q2 Planning

eseliger commented 4 years ago

W12 Summary

Some improvements and fixes to the E2E pipeline
Worked on details for RFC135
Planning for campaign beta pages and delivery plan
Found some low hanging fruit on our page response times
Interviews and discussed enhancements to our process

W13 Plan

Campaigns open beta preparation work
Interviews

felixfbecker commented 4 years ago

W12 summary

Improve changeset creation errors #9416
Fix action bar design #9503
Improve accessibility focus rings #9532
Respect rev when jumping to Sourcegraph #9520
Add icons to CodeCov and git blame extensions
Quick fix debug menu background #9518
Don't break GitHub and Bitbucket file toolbar #9517, #9522
Debt cleanup: #9490, #9472
Linting improvements: https://github.com/sourcegraph/eslint-config/pull/66, https://github.com/sourcegraph/eslint-config/pull/70
1 interview

W13 plan

Improve interview ~~architecture~~ library design instructions https://github.com/sourcegraph/interviews/pull/86
Add test coverage tracking for Puppeteer tests
Work on RFC
2 interviews
TBD

attfarhan commented 4 years ago

W12 summary

Graded 3 coding screens
1 coding screen follow-up call
Worked on onboarding changes (https://github.com/sourcegraph/sourcegraph/issues/8584)
Looked into Reach UI, and beginning to introduce it through the onboarding changes (https://github.com/sourcegraph/sourcegraph/issues/6443)

W13 Plan

Wrap up onboarding changes (just need to make tests pass by mocking a Reach UI component)
Replace remaining Reactstrap components with Reach UI
https://github.com/sourcegraph/sourcegraph/issues/4710
stretch: Begin writing RFC for making search bar in interactive mode only take in the search pattern for 3.16

eseliger commented 4 years ago

W13 summary

2 Interviews, 2 code screens
Fixed a customer issue #9656
Worked on campaigns splash screens
Some debt work reducing code smells #9696

W14 Plan

Wrap up campaigns work for 3.16

lguychard commented 4 years ago

W13 Summary

I ended up spending my time last week between customer inquiries / bugs, the hiring pipeline, and being sick, and was not able to move forward on iteration work 😞

W14 Plan

Make progress on my outstanding work for 3.15, triage what will not make the branch cut.
Q2 planning.

uwedeportivo commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.15 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you

felixfbecker commented 4 years ago

W14 Recap

Fix code intel paper cut issues (#9914, https://github.com/sourcegraph/codeintellify/pull/251)
Fix "Function of extension-contributed buttons is not clear" (details in https://github.com/sourcegraph/sourcegraph/issues/5488#issuecomment-613288907)
Add tooling for tracking npm third party licenses (#9823)
Small fix: #9800
ESLint and build tooling upgrades in external repos
Some CI fixes
Planning of RFC 144: Code Insights

lguychard commented 4 years ago

@felixfbecker can you repost your update in #9915?

See https://sourcegraph.slack.com/archives/CMT39K56Z/p1587366606183100?thread_ts=1587366046.182900&cid=CMT39K56Z

Thanks 🙂

felixfbecker commented 4 years ago

But last week was still 3.15 work? I was planning to post my W15 plan on #9915. Am I thinking about this wrong?

sourcegraph / sourcegraph-public-snapshot