Syntax highlighting in dark theme has less color variation than in light theme

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.1k stars 1.27k forks source link

Syntax highlighting in dark theme has less color variation than in light theme #925

Open felixfbecker opened 5 years ago

felixfbecker commented 5 years ago

Thanks to Mojave I got into dark theme again, but I noticed that code is significantly harder to read because it has less color variation in syntax highlighting:

In light theme, this is red and the keywords in the parameter types are green. In dark theme, they are all the light blue of the rest of the code. Also, in light theme, control-flow keywords like if are green, which is very different from the light blue of the rest of the code. But in dark theme, they are just dark blue, which is a lot less different.

Here is the same snippet in VS Code with the Sourcegraph Dark theme:

Note how types are green, and control-flow keywords are purple. This is how the dark theme on Sourcegraph should look like

slimsag commented 5 years ago

To clarify, the fix for this is what I mentioned in https://github.com/sourcegraph/sourcegraph/issues/1341#issuecomment-446302797

Additionally, a theme switcher would help by allowing you to select more arbitrary themes (which would not 'fit in' with the rest of Sourcegraph via a user setting). This is not a fix, but is a related / helpful addition.