Fix error property propagation from background pages

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.11k stars 1.29k forks source link

Fix error property propagation from background pages #9693

Open felixfbecker opened 4 years ago

felixfbecker commented 4 years ago

Currently, errors that go through the background-content-page boundary lose their error name: https://github.com/mozilla/webextension-polyfill/issues/210. This means we need to use hacky string message assertion and cannot include any other context. This has caused multiple bugs (e.g. #9411, #7599, ...) and many hours of engineering time lost.

names could always be propagated, custom properties are a bit more tricky because they may not be cloneable.

[x] Fix in comlink: @felixfbecker
[ ] Fix in webextension-polyfill: @lguychard has a branch to fix this

uwedeportivo commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.16 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you

uwedeportivo commented 4 years ago

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.17 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly. When in doubt, reach out!

Thank you

github-actions[bot] commented 3 years ago

Heads up @joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.

vdavid commented 2 years ago

This is probably still an issue and would improve our tooling if fixed.