search

sourcegraph / src-cli

Sourcegraph CLI
https://sourcegraph.com
Apache License 2.0
267 stars 57 forks source link

Clean up volumes if workspace preparation fails #1021

Closed lowjoel closed 10 months ago

lowjoel commented 11 months ago

If workspace preparation fails, the temporary Docker volume is not cleaned up.

Test plan

I'll need help filling in this bit. Apart from manually inducing an error with the workspace process, how else? I could possibly build locally a broken batch-change container image that doesn't have Git nor unzip?

lowjoel commented 11 months ago

I also fixed the tests this round. Let me know what you think.