search

sourcegraph / src-cli

Sourcegraph CLI
https://sourcegraph.com
Apache License 2.0
267 stars 57 forks source link

src code-intel upload converts SCIP to LSIF for sourcegraph.com uploads on 401 failure #1032

Closed varungandhi-src closed 10 months ago

varungandhi-src commented 10 months ago

On a 401 failure, we should exit early.

❯ SRC_ACCESS_TOKEN=lol src code-intel upload
ℹ️  Converting index.scip into dump.lsif
💡 Inferred arguments
   repo: github.com/Workiva/over_react
   commit: ab689643a0c06b921ce84872bd7cee37a08cf11f
   root:
   file: dump.lsif
   indexer: scip-dart
   indexerVersion: 1.1.4

The current code misinterprets the 401 failure as a missing endpoint for accepting SCIP uploads