search

sourcegraph / src-cli

Sourcegraph CLI
https://sourcegraph.com
Apache License 2.0
267 stars 57 forks source link

servegit: use error hook #1037

Closed keegancsmith closed 10 months ago

keegancsmith commented 10 months ago

Before this if the git command failed we would nil panic since the Logger on gitservice.Handler was not set. This commit updates us to the latest version of lib which instead takes in an error hook so we can use the attached stdlib logger.

Corresponding PR at https://github.com/sourcegraph/sourcegraph/pull/56611

Test Plan: go test

keegancsmith commented 10 months ago

@DaedalusG fix for the nil panic is now in main :)